Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor][C++] Fix compile warning #123

Merged
merged 1 commit into from
Mar 17, 2023
Merged

[Minor][C++] Fix compile warning #123

merged 1 commit into from
Mar 17, 2023

Conversation

yixinglu
Copy link
Contributor

Proposed changes

minor change: fix the warning when compiling GraphAr, such as:

In file included from /home/yee.yi/Workspace/GraphAr/cpp/include/gar/utils/filesystem.h:23,
                 from /home/yee.yi/Workspace/GraphAr/cpp/src/filesystem.cc:26:
/home/yee.yi/Workspace/GraphAr/cpp/src/filesystem.cc: In instantiation of ‘GraphArchive::Result<T> GraphArchive::FileSystem::ReadFileToValue(const string&) const [with T = long int; GraphArchive::Result<T> = cpp::
bitwizeshift::result<long int, GraphArchive::Status>; std::string = std::__cxx11::basic_string<char>]’:
/home/yee.yi/Workspace/GraphAr/cpp/src/filesystem.cc:271:31:   required from here
/home/yee.yi/Workspace/GraphAr/cpp/src/filesystem.cc:156:45: warning: unused variable ‘bytes’ [-Wunused-variable]
  156 |   GAR_RETURN_ON_ARROW_ERROR_AND_ASSIGN(auto bytes,
      |                                             ^~~~~
/home/yee.yi/Workspace/GraphAr/cpp/include/gar/utils/result.h:87:3: note: in definition of macro ‘GAR_RETURN_ON_ARROW_ERROR_AND_ASSIGN_IMPL’
   87 |   lhs = std::move(result_name).ValueOrDie();
      |   ^~~
/home/yee.yi/Workspace/GraphAr/cpp/src/filesystem.cc:156:3: note: in expansion of macro ‘GAR_RETURN_ON_ARROW_ERROR_AND_ASSIGN’
  156 |   GAR_RETURN_ON_ARROW_ERROR_AND_ASSIGN(auto bytes,
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[100%] Linking CXX shared library libgar.so

@CLAassistant
Copy link

CLAassistant commented Mar 16, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Mar 16, 2023

🎊 PR Preview f197e43 has been successfully built and deployed to https://alibaba-graphar-build-pr-123.surge.sh

🤖 By surge-preview

@lixueclaire lixueclaire requested a review from acezen March 16, 2023 01:32
Copy link
Contributor

@acezen acezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@acezen acezen changed the title Fix compile warning [Minor][C++] Fix compile warning Mar 17, 2023
@acezen acezen merged commit c03ce2a into apache:main Mar 17, 2023
@yixinglu yixinglu deleted the fix-warn branch March 17, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants