[ISSUE#4496] Fix gradle dist error. #4497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pil0tXia
reviewed
Oct 19, 2023
Pil0tXia
reviewed
Oct 19, 2023
Comment on lines
40
to
45
| } | ||
|
|
||
| spotlessJava.enabled false | ||
|
|
||
| protobuf { | ||
| protoc { artifact = "com.google.protobuf:protoc:${protocVersion}" } |
There was a problem hiding this comment.
You said "now this problem is solved in a general way, and there is no need to remove spotless tasks", then why this config is added here?
There was a problem hiding this comment.
Sorry, I missed it, fixed.
pandaapo
reviewed
Oct 19, 2023
pandaapo
reviewed
Oct 19, 2023
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ |
There was a problem hiding this comment.
I think it can be kept for the future to customize the build script.
Codecov Report
@@ Coverage Diff @@
## master #4497 +/- ##
============================================
- Coverage 15.46% 15.45% -0.01%
Complexity 1452 1452
============================================
Files 691 691
Lines 28101 28095 -6
Branches 2624 2610 -14
============================================
- Hits 4345 4343 -2
+ Misses 23309 23308 -1
+ Partials 447 444 -3 see 19 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Pil0tXia
approved these changes
Oct 20, 2023
mxsm
approved these changes
Oct 20, 2023
pandaapo
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4496 .
Modifications
Declare correct gradle task dependencies.