Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #4472]Fix MeshMessageProtocolAdaptor#fromCloudEvent throw NPE #4473

Merged
merged 1 commit into from
Oct 7, 2023
Merged

[ISSUE #4472]Fix MeshMessageProtocolAdaptor#fromCloudEvent throw NPE #4473

merged 1 commit into from
Oct 7, 2023
+15 −13

Conversation

mxsm
Copy link
Member

@mxsm mxsm commented Oct 6, 2023

Fixes #4472

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

  • Fix MeshMessageProtocolAdaptor#fromCloudEvent throw NPE

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Oct 6, 2023 •
edited
Loading

Codecov Report

Merging #4473 (99de782) into master (b6f9ca5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 99de782 differs from pull request most recent head 8f72bf5. Consider uploading reports for the commit 8f72bf5 to get more accurate results

@@             Coverage Diff              @@
##             master    #4473      +/-   ##
============================================
- Coverage     15.58%   15.58%   -0.01%     
+ Complexity     1476     1475       -1     
============================================
  Files           698      698              
  Lines         28203    28205       +2     
  Branches       2633     2633              
============================================
  Hits           4396     4396              
- Misses        23360    23361       +1     
- Partials        447      448       +1
Files Coverage Δ
...in/java/org/apache/eventmesh/common/Constants.java 75.00% <ø> (ø)
...otocol/meshmessage/MeshMessageProtocolAdaptor.java 4.34% <100.00%> (ø)
...tocol/meshmessage/MeshMessageProtocolConstant.java 0.00% <ø> (ø)
...h/client/grpc/util/EventMeshCloudEventBuilder.java 79.38% <100.00%> (+0.31%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Pil0tXia
Pil0tXia approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxsm mxsm merged commit c8b7916 into apache:master Oct 7, 2023
@mxsm mxsm deleted the eventmesh-bug-4472 branch October 7, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alonexc Alonexc Alonexc approved these changes

@Pil0tXia Pil0tXia Pil0tXia approved these changes

@pandaapo pandaapo pandaapo approved these changes

@xwm1992 xwm1992 xwm1992 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]MeshMessageProtocolAdaptor#fromCloudEvent throw NPE
5 participants
@mxsm @xwm1992 @pandaapo @Pil0tXia @Alonexc