Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE 4346] Fix start error and some code optimization. #4347

Merged
merged 2 commits into from
Aug 11, 2023
Merged

[ISSUE 4346] Fix start error and some code optimization. #4347

merged 2 commits into from
Aug 11, 2023

Conversation

Alonexc
Copy link
Contributor

@Alonexc Alonexc commented Aug 10, 2023

Fixes #4346 .

Motivation

fix start error and some code optimization

Modifications

fix start error and some code optimization

Documentation

  • Does this pull request introduce a new feature? no

@codecov
Copy link

codecov bot commented Aug 10, 2023 •
edited
Loading

Codecov Report

Merging #4347 (6ca7264) into master (d3d9d4f) will not change coverage.
The diff coverage is n/a.

❗ Current head 6ca7264 differs from pull request most recent head 27d0ffe. Consider uploading reports for the commit 27d0ffe to get more accurate results

@@            Coverage Diff            @@
##             master    #4347   +/-   ##
=========================================
  Coverage     16.69%   16.69%           
  Complexity     1393     1393           
=========================================
  Files           594      594           
  Lines         25348    25348           
  Branches       2393     2393           
=========================================
  Hits           4233     4233           
  Misses        20685    20685           
  Partials        430      430

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xwm1992 xwm1992 merged commit dec34f3 into apache:master Aug 11, 2023
@Alonexc Alonexc deleted the fix_start_error branch August 11, 2023 01:55
xwm1992 added a commit to xwm1992/EventMesh that referenced this pull request Aug 29, 2023
@xwm1992
[ISSUE apache#4347] Redesign registry module into meta storage
00d5a2e
@xwm1992 xwm1992 mentioned this pull request Aug 29, 2023
Merged
xwm1992 added a commit that referenced this pull request Aug 30, 2023
@xwm1992
[ISSUE #4374] Redesign registry module into meta storage (#4418)
5d390d3 
* [ISSUE #4347] Redesign registry module into meta storage

* fix ci check error

* fix ci check error

* fix ci check error

* fix ci check error

* fix ci check error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pandaapo pandaapo pandaapo approved these changes

@xwm1992 xwm1992 xwm1992 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] http demo AsyncPublishInstance test fail.
3 participants
@Alonexc @xwm1992 @pandaapo