Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE 4239] Optimal http header hard-code #4295

Merged
merged 4 commits into from
Jul 30, 2023
Merged

[ISSUE 4239] Optimal http header hard-code #4295

merged 4 commits into from
Jul 30, 2023

Conversation

Alonexc
Copy link
Contributor

@Alonexc Alonexc commented Jul 27, 2023 •
edited
Loading

Fixes #4239.

Motivation

Optimal http header hard-code

Modifications

Optimal http header hard-code

Documentation

  • Does this pull request introduce a new feature? no

@codecov
Copy link

codecov bot commented Jul 27, 2023 •
edited
Loading

Codecov Report

Merging #4295 (10cce2e) into master (c18ef05) will decrease coverage by 0.52%.
Report is 3 commits behind head on master.
The diff coverage is 47.08%.

❗ Current head 10cce2e differs from pull request most recent head 1358a17. Consider uploading reports for the commit 1358a17 to get more accurate results

@@             Coverage Diff              @@
##             master    #4295      +/-   ##
============================================
- Coverage     16.87%   16.35%   -0.52%     
+ Complexity     1426     1358      -68     
============================================
  Files           593      594       +1     
  Lines         26068    25446     -622     
  Branches       2396     2410      +14     
============================================
- Hits           4398     4161     -237     
+ Misses        21229    20848     -381     
+ Partials        441      437       -4
Files Changed Coverage Δ
...entmesh/common/protocol/http/HttpEventWrapper.java 0.00% <0.00%> (ø)
.../header/message/SendMessageBatchRequestHeader.java 0.00% <0.00%> (ø)
...header/message/SendMessageBatchResponseHeader.java 0.00% <0.00%> (ø)
...eader/message/SendMessageBatchV2RequestHeader.java 0.00% <0.00%> (ø)
...ader/message/SendMessageBatchV2ResponseHeader.java 0.00% <0.00%> (ø)
.../http/header/message/SendMessageRequestHeader.java 0.00% <0.00%> (ø)
...http/header/message/SendMessageResponseHeader.java 0.00% <0.00%> (ø)
...olver/http/SendMessageBatchV2ProtocolResolver.java 0.00% <0.00%> (ø)
...olver/http/SendMessageRequestProtocolResolver.java 0.00% <0.00%> (ø)
...time/admin/handler/DeleteWebHookConfigHandler.java 26.66% <ø> (ø)
... and 57 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

mxsm
mxsm approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxsm mxsm merged commit a7b24ea into apache:master Jul 30, 2023
@Alonexc Alonexc deleted the optimal_4239 branch July 31, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxsm mxsm mxsm approved these changes

@xwm1992 xwm1992 xwm1992 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Hard-coded optimization.
3 participants
@Alonexc @xwm1992 @mxsm