Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4267] Optimized [GrpcEventMeshCloudEventProtocolResolver] #4279

Merged
merged 7 commits into from
Jul 25, 2023
Merged

[ISSUE #4267] Optimized [GrpcEventMeshCloudEventProtocolResolver] #4279

merged 7 commits into from
Jul 25, 2023

Conversation

devCod3r
Copy link
Contributor

Fixes #4267

Motivation

Optimized the class GrpcEventMeshCloudEventProtocolResolver.
Issue #4267

Modifications

Few optimizations has been made to the class GrpcEventMeshCloudEventProtocolResolver.

Documentation

  • Does this pull request introduce a new feature?
  • Ans: No
  • If a feature is not applicable for documentation, explain why?
  • Ans: Only few optimizations has been made to the mentioned class.

@Alonexc
Copy link
Contributor

Alonexc commented Jul 25, 2023

image
please check checkstyle.

Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #4279 (c51a25a) into master (984eacc) will not change coverage.
The diff coverage is n/a.

❗ Current head c51a25a differs from pull request most recent head 11c5639. Consider uploading reports for the commit 11c5639 to get more accurate results

@@            Coverage Diff            @@
##             master    #4279   +/-   ##
=========================================
  Coverage     16.87%   16.87%           
  Complexity     1426     1426           
=========================================
  Files           593      593           
  Lines         26068    26068           
  Branches       2396     2396           
=========================================
  Hits           4398     4398           
  Misses        21229    21229           
  Partials        441      441           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mxsm mxsm merged commit fe13a85 into apache:master Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Some optimizations to GrpcEventMeshCloudEventProtocolResolver.
5 participants