Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #4109 ] Code Optimization.[ClientGroupWrapper] #4154

Merged
merged 2 commits into from
Jun 27, 2023
Merged

[ISSUE #4109 ] Code Optimization.[ClientGroupWrapper] #4154

merged 2 commits into from
Jun 27, 2023

Conversation

nitheesh-daram
Copy link
Contributor

Fixes #4109

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@nitheesh-daram
Resolves #4109
2347eb7 
Signed-off-by: Nitheesh Daram <54185106+nitheesh-daram@users.noreply.github.com>
Alonexc
Alonexc reviewed Jun 26, 2023
View reviewed changes
Copy link
Contributor

@Alonexc Alonexc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue description requires the fianl modifier to be added to the attribute. and please check checkstyle.

@nitheesh-daram
Resolves #4109
4a92815 
Code Review Changes

Signed-off-by: Nitheesh Daram <54185106+nitheesh-daram@users.noreply.github.com>
@nitheesh-daram nitheesh-daram requested a review from Alonexc June 26, 2023 06:15
@nitheesh-daram
Copy link
Contributor Author

The issue description requires the fianl modifier to be added to the attribute. and please check checkstyle.

Made the code review changes

Alonexc
Alonexc approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@Alonexc Alonexc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #4154 (d5f54cb) into master (991cbda) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head d5f54cb differs from pull request most recent head 4a92815. Consider uploading reports for the commit 4a92815 to get more accurate results

@@             Coverage Diff              @@
##             master    #4154      +/-   ##
============================================
- Coverage     16.93%   16.91%   -0.03%     
  Complexity     1410     1410              
============================================
  Files           588      588              
  Lines         25739    25753      +14     
  Branches       2387     2380       -7     
============================================
- Hits           4358     4355       -3     
- Misses        20946    20964      +18     
+ Partials        435      434       -1
Impacted Files Coverage Δ
.../protocol/tcp/client/group/ClientGroupWrapper.java 0.00% <0.00%> (ø)
...ol/tcp/client/group/ClientSessionGroupMapping.java 0.77% <0.00%> (-0.01%) ⬇️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

lrhkobe
lrhkobe approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@lrhkobe lrhkobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xwm1992 xwm1992 merged commit 12aeb4b into apache:master Jun 27, 2023
@pandaapo pandaapo mentioned this pull request Nov 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alonexc Alonexc Alonexc approved these changes

@lrhkobe lrhkobe lrhkobe approved these changes

@xwm1992 xwm1992 xwm1992 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Do some code optimization.[ClientGroupWrapper]
4 participants
@nitheesh-daram @xwm1992 @lrhkobe @Alonexc