Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3472]Do some code optimization[HttpProtocolAdaptor] #3884

Merged
merged 2 commits into from
May 16, 2023

Conversation

harshithasudhakar
Copy link
Member

Fixes #3472

Modifications

Imported java.util.Objects
Used Objects.requireNonNull() at line 95

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

Imported `java.util.Objects`
Used 'Objects.requireNonNull()' at line 95
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #3884 (a9a03b4) into master (e1e9aca) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head a9a03b4 differs from pull request most recent head 107ee20. Consider uploading reports for the commit 107ee20 to get more accurate results

@@            Coverage Diff            @@
##             master    #3884   +/-   ##
=========================================
  Coverage     13.93%   13.93%           
- Complexity     1291     1292    +1     
=========================================
  Files           570      570           
  Lines         28847    28847           
  Branches       2811     2811           
=========================================
+ Hits           4019     4021    +2     
+ Misses        24455    24454    -1     
+ Partials        373      372    -1     
Impacted Files Coverage Δ
...col/http/resolver/HttpRequestProtocolResolver.java 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@mroccyen mroccyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mroccyen mroccyen merged commit 3bf8aed into apache:master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Do some code optimization[HttpProtocolAdaptor]
4 participants