Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #3852]Replace some logic with existing APIs. Merge some logic. #3854

Merged
merged 3 commits into from
May 9, 2023
Merged

[ISSUE #3852]Replace some logic with existing APIs. Merge some logic. #3854

merged 3 commits into from
May 9, 2023

Conversation

pandaapo
Copy link
Member

@pandaapo pandaapo commented May 1, 2023

Fixes #3852.

Motivation

See detail in issue "Enhancement Request"

Modifications

See detail in issue "Describe the solution you'd like".

Documentation

  • Does this pull request introduce a new feature? no

Alonexc
Alonexc approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@Alonexc Alonexc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 5, 2023 •
edited
Loading

Codecov Report

Merging #3854 (e529855) into master (91aab4d) will increase coverage by 0.02%.
The diff coverage is 7.14%.

❗ Current head e529855 differs from pull request most recent head 68c0c22. Consider uploading reports for the commit 68c0c22 to get more accurate results

@@             Coverage Diff              @@
##             master    #3854      +/-   ##
============================================
+ Coverage     13.77%   13.80%   +0.02%     
  Complexity     1290     1290              
============================================
  Files           571      571              
  Lines         29129    29093      -36     
  Branches       2837     2840       +3     
============================================
+ Hits           4012     4015       +3     
+ Misses        24745    24705      -40     
- Partials        372      373       +1
Impacted Files Coverage Δ
...olver/http/SendMessageBatchV2ProtocolResolver.java 0.00% <0.00%> (ø)
...olver/http/SendMessageRequestProtocolResolver.java 0.00% <0.00%> (ø)
...ssage/resolver/tcp/TcpMessageProtocolResolver.java 0.00% <0.00%> (ø)
...mesh/storage/kafka/consumer/KafkaConsumerImpl.java 9.09% <ø> (ø)
.../knative/cloudevent/impl/KnativeMessageWriter.java 61.11% <0.00%> (ø)
...eventmesh/storage/pravega/PravegaConsumerImpl.java 16.66% <ø> (ø)
...torage/pravega/client/PravegaCloudEventWriter.java 0.00% <ø> (ø)
...standalone/consumer/StandaloneConsumerAdaptor.java 0.00% <0.00%> (ø)
...che/eventmesh/trace/jaeger/JaegerTraceService.java 60.00% <ø> (ø)
...eventmesh/trace/pinpoint/PinpointTraceService.java 52.17% <ø> (ø)
... and 3 more

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xwm1992 xwm1992 merged commit 96ee1e9 into apache:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alonexc Alonexc Alonexc approved these changes

@xwm1992 xwm1992 xwm1992 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Replace some logic with existing APIs. Merge some logic.
3 participants
@pandaapo @xwm1992 @Alonexc