[ISSUE #3849]GrpcMessageProtocolResolver has many unused variables and repetitive method def. #3850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My desktop won't connect to my modem/hotspot s🤨 |
The community welcomes discussions, questions, contributions, and other technical related content, but please do not post such comments that have no meaning. |
Codecov Report
@@ Coverage Diff @@
## master #3850 +/- ##
============================================
+ Coverage 13.77% 13.79% +0.02%
Complexity 1290 1290
============================================
Files 571 571
Lines 29129 29098 -31
Branches 2837 2844 +7
============================================
+ Hits 4012 4015 +3
+ Misses 24745 24710 -35
- Partials 372 373 +1
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xwm1992
approved these changes
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3849.
Fixes #3839
Motivation
org.apache.eventmesh.protocol.cloudevents.resolver.grpc.GrpcMessageProtocolResolver:
Many unused variable in
buildBatchEvents().getMessageItemValue()andgetHeaderValue()have the same body.Some logic ignore the existing api.
And so on.
Modifications
Remove unused variables and repetitive method. Use existing api. And other modifications.
Documentation