Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] GrpcMessageProtocolResolver has many unused variables and repetitive method def. #3849

Closed
2 tasks done
pandaapo opened this issue Apr 29, 2023 · 0 comments · Fixed by #3850
Closed
2 tasks done

[Enhancement] GrpcMessageProtocolResolver has many unused variables and repetitive method def. #3849

pandaapo opened this issue Apr 29, 2023 · 0 comments · Fixed by #3850
Labels
enhancement New feature or request

Comments

@pandaapo
Copy link
Member

pandaapo commented Apr 29, 2023 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

org.apache.eventmesh.protocol.cloudevents.resolver.grpc.GrpcMessageProtocolResolver:

Many unused variable in buildBatchEvents().

getMessageItemValue() and getHeaderValue() have the same body.

Some logic ignore the existing api.

More code can be extracted into builderCloudEventBuilder().

getEventExtension(CloudEvent event, String protocolKey) is unused.

Describe the solution you'd like

Remove unused variables.
Use existing api.
Extract more code into builderCloudEventBuilder().
remove getEventExtension(CloudEvent event, String protocolKey) .

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@pandaapo pandaapo added the enhancement New feature or request label Apr 29, 2023
@pandaapo pandaapo mentioned this issue Apr 29, 2023
Merged
xwm1992 pushed a commit that referenced this issue May 6, 2023
@pandaapo
[ISSUE #3849]GrpcMessageProtocolResolver has many unused variables an…
733d6ef 
…d repetitive method def. (#3850)

* many unused variables and repetitive method def.

* modify wrong api usage.

* Revoke controversial import static.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@pandaapo