Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Method invocation may produce 'NullPointerException'.[CloudEventsProtocolAdaptor] #3649

Closed
1 of 2 tasks
Alonexc opened this issue Apr 7, 2023 · 0 comments · Fixed by #3660
Closed
1 of 2 tasks

[Enhancement] Method invocation may produce 'NullPointerException'.[CloudEventsProtocolAdaptor] #3649

Alonexc opened this issue Apr 7, 2023 · 0 comments · Fixed by #3660
Labels
enhancement New feature or request good first issue Issues for first-time contributors

Comments

@Alonexc
Copy link
Contributor

Alonexc commented Apr 7, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

image
located at:
eventmesh-protocol-plugin/eventmesh-protocol-cloudevents/src/main/java/org/apache/eventmesh/protocol/cloudevents/CloudEventsProtocolAdaptor.java line 121,130

Describe the solution you'd like

image

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@Alonexc Alonexc added the enhancement New feature or request label Apr 7, 2023
@Alonexc Alonexc mentioned this issue Apr 7, 2023
Open
@kyooosukedn kyooosukedn mentioned this issue Apr 7, 2023
Merged
@xwm1992 xwm1992 added the good first issue Issues for first-time contributors label Apr 10, 2023
xwm1992 pushed a commit that referenced this issue Apr 13, 2023
@kyooosukedn
[ISSUE #3649] Method invocation may produce 'NullPointerException'.[C…
906fcdb 
…loudEventsProtocolAdaptor] (#3660)

[ISSUE #3649] Method invocation may produce 'NullPointerException'.[CloudEventsProtocolAdaptor]
dipankr added a commit to dipankr/eventmesh that referenced this issue Apr 13, 2023
@dipankr
apache#3649 added Objects.requireNonNull to prevent NullPointerException
908b594 
removed 'T extends ProtocolTransportObject' as it was giving a warning that T is never used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Issues for first-time contributors
Projects
None yet
Milestone
No milestone
2 participants
@xwm1992 @Alonexc