Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ServiceConfigURLDelegate for protostuff #67

Merged
merged 11 commits into from
Nov 14, 2023
Merged

add ServiceConfigURLDelegate for protostuff #67

merged 11 commits into from
Nov 14, 2023

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Sep 14, 2021

What is the purpose of the change

  • add protostuff serialization
  • fix ServiceConfigURL of dubbo 3.0 serialization problem: public parameters such as application,version are not be transferred

@zrlw zrlw mentioned this pull request Sep 14, 2021
Closed
2 tasks
@zrlw
Copy link
Contributor Author

zrlw commented Sep 14, 2021

@xiaoheng1

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2021 •
edited
Loading

Codecov Report

Merging #67 (1abe508) into master (b100785) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #67   +/-   ##
=========================================
  Coverage     36.80%   36.80%           
  Complexity       61       61           
=========================================
  Files            30       30           
  Lines           644      644           
  Branches         74       74           
=========================================
  Hits            237      237           
  Misses          386      386           
  Partials         21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b100785...1abe508. Read the comment docs.

@songxiaosheng
Copy link
Member

please fix conficts, thanks

@zrlw
Copy link
Contributor Author

zrlw commented Nov 13, 2023

please fix conficts, thanks

fixed. I'm surprised that this PR committed two years ago is still existed.

@songxiaosheng
Copy link
Member

please fix conficts, thanks

fixed. I'm surprised that this PR committed two years ago is still existed.
thanks，we can try merge it

@zrlw
Copy link
Contributor Author

zrlw commented Nov 14, 2023

re-enable test_URL_mutable_withType at AbstractSerializationTest.java since it could be also used by KryoPersonOkTest and KyroSerializationTest.

songxiaosheng
songxiaosheng approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songxiaosheng songxiaosheng merged commit d1664f7 into apache:master Nov 14, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songxiaosheng songxiaosheng songxiaosheng approved these changes

@AlbumenJ AlbumenJ AlbumenJ approved these changes

@xiaoheng1 xiaoheng1 Awaiting requested review from xiaoheng1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zrlw @codecov-commenter @songxiaosheng @AlbumenJ