Fix fury bug #476
Fix fury bug #476
Conversation
|
After testing, there are still issues with deserialization. |
|
please fix conflict |
have done |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #476 +/- ##
===========================================
- Coverage 0.27% 0.00% -0.28%
===========================================
Files 299 521 +222
Lines 13730 17254 +3524
Branches 1737 2010 +273
===========================================
- Hits 38 0 -38
- Misses 13689 17254 +3565
+ Partials 3 0 -3 ☔ View full report in Codecov by Sentry. |
|
@chaokunyang PTAL |
| @@ -40,7 +40,7 @@ public FuryObjectInput(Fury fury, MemoryBuffer buffer, InputStream input) { | |||
|
|
|||
| @Override | |||
| public Object readObject() { | |||
| return fury.deserialize(new FuryInputStream(input, buffer.size())); | |||
| return fury.deserializeJavaObjectAndClass(new FuryInputStream(input, buffer.size())); | |||
There was a problem hiding this comment.
Could we use BlockedStreamUtils.deserialize(fury, output, obj); and BlockedStreamUtils.serialize(fury, output, obj); instead?
FuryInputStream will buffer data internally for speed, which may read more data than needed
...ization-fury/src/main/java/org/apache/dubbo/common/serialize/fury/dubbo/FuryObjectInput.java
Outdated
Show resolved
Hide resolved
What is the purpose of the change
Fix fury bug
apache/dubbo#14536
Brief changelog
Fix FuryInputStream.java.By the way,add more tests.
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
just this issue, without pulling in other changes - one PR resolves one issue.
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commitin the pull request should have a meaningful subject line and body.
exist. If the new feature or significant change is committed, please remember to add sample
in dubbo samples project.
mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sureunit-test and integration-test pass.
the Software Donation Guide.