Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: compatible dubbo 3.0.x #336

Merged
merged 6 commits into from
May 9, 2024
Merged

Conversation

aofall
Copy link
Contributor

@aofall aofall commented Apr 29, 2024

What is the purpose of the change

  1. Use rivision tag manager version and Bump version to 3.0.0-SNAPSHOT
  2. Cherry pick bug fix from master branch
  3. fix test case failed
  4. Remove dubbo-registry-dns module because ReflectionBasedServiceDiscovery since dubbo 3.1

Brief changelog

compatible dubbo 3.0.x

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before
    you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
    just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit
    in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
    exist. If the new feature or significant change is committed, please remember to add sample
    in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure
    unit-test and integration-test pass.
  • If this contribution is large, please follow
    the Software Donation Guide.

aofall and others added 6 commits March 19, 2024 20:55
* upgrade dubbo to the 3.1.x the latest version

* fix(apache#207): Dubbo Redis register support select databases

(cherry picked from commit 0f42ecd)
* Remove dubbo-gateway-common module

because the class ByteAccessor since dubbo 3.2.0, but this branch(3.1.0) based on the dubbo 3.1.x

* Bump the extensions version to 3.1.0 && revision the pom.xml

* Adjust test ci workspace

* add GitHub Actions workflow file

* add GitHub Actions workflow file

* build: add some ignore file for license check

* chore: fix missed or incorrect ASF license

* fix multi os prepare test failed

* fix test case failed

* try to fix conformance test failed

* try to fix conformance test failed

* fix ci build failed
* [Dubbo-267] Fix protobuf type lose field when deepCopy inJvmInvoker Class. (apache#268)

* fix: dubbo-registry-dns resource leak (apache#308)

* fix: dubbo-registry-dns memory leak && add try catch

* revert junit

(cherry picked from commit b3033de)

* fix: redis connection do not close and return to connection pool (apache#311)

(cherry picked from commit cbad15d)

* fix test lib (apache#310)

* fix test lib

* remove useless dependency

* remove useless dependency

* fix bad test

* TimeoutException Increase time

* Revert "TimeoutException Increase time"

This reverts commit 5e5bb32.

* add MinaClientToServerTest disable

(cherry picked from commit f38363f)

* build: add Windows platform unit test for CI && add dependabot config

* chore: create etcd for each unit test

* chore: already check license by apache skywalking-eyes so skip rat-license check

* Revert "chore: already check license by apache skywalking-eyes so skip rat-license check"

This reverts commit 98d627b.

* fix: rat-check failed

---------

Co-authored-by: MaruHibiki <1807180752@qq.com>
Co-authored-by: 王聪洋 <56506697+wcy666103@users.noreply.github.com>
Remove dubbo-registry-dns because ReflectionBasedServiceDiscovery since dubbo 3.1
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 31.37%. Comparing base (2752e83) to head (c895ca4).

Files Patch % Lines
...apache/dubbo/rpc/rocketmq/codec/RocketMQCodec.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              3.0.0     #336      +/-   ##
============================================
- Coverage     34.04%   31.37%   -2.67%     
+ Complexity      506      459      -47     
============================================
  Files           156      149       -7     
  Lines          5326     5201     -125     
  Branches        662      654       -8     
============================================
- Hits           1813     1632     -181     
- Misses         3314     3396      +82     
+ Partials        199      173      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ
Copy link
Member

AlbumenJ commented May 8, 2024

@songxiaosheng PTAL

@aofall
Copy link
Contributor Author

aofall commented May 8, 2024

@AlbumenJ Could you please retrigger the workflow of Build and Test For PR / Unit Test ubuntu-latest with JDK 8

It works fine on my own repository. https://github.com/aofall/dubbo-spi-extensions/actions/runs/8875523227

@songxiaosheng
Copy link
Member

please fix ci problem

606Z [INFO] Running org.apache.dubbo.rpc.cluster.loadbalance.PeakEwmaLoadBalanceTest
2024-04-29T09:36:22.7778212Z [ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 4.691 s <<< FAILURE! - in org.apache.dubbo.rpc.cluster.loadbalance.PeakEwmaLoadBalanceTest
2024-04-29T09:36:22.7788736Z [ERROR] testWithShake  Time elapsed: 2.337 s  <<< FAILURE!
2024-04-29T09:36:22.7800022Z org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
2024-04-29T09:36:22.7806357Z 	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
2024-04-29T09:36:22.7812762Z 	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
2024-04-29T09:36:22.7818645Z 	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
2024-04-29T09:36:22.7824182Z 	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
2024-04-29T09:36:22.7829759Z 	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
2024-04-29T09:36:22.7836287Z 	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:180)
2024-04-29T09:36:22.7850320Z 	at org.apache.dubbo.rpc.cluster.loadbalance.PeakEwmaLoadBalanceTest.testWithShake(PeakEwmaLoadBalanceTest.java:76)
2024-04-29T09:36:22.7862261Z 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2024-04-29T09:36:22.7867960Z 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
2024-04-29T09:36:22.7876823Z 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2024-04-29T09:36:22.7880811Z 	at java.lang.reflect.Method.invoke(Method.java:498)
2024-04-29T09:36:22.7887588Z 	at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:727)
2024-04-29T09:36:22.7889466Z 	at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
2024-04-29T09:36:22.7895040Z 	at 

@songxiaosheng songxiaosheng merged commit 6b534a8 into apache:3.0.0 May 9, 2024
16 checks passed
@aofall aofall mentioned this pull request May 17, 2024
6 tasks
@aofall aofall deleted the 3.0-compatible branch November 14, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants