Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: try to fix etcd unit test failed sometimes #312

Merged
merged 13 commits into from
Apr 27, 2024
Merged

fix: try to fix etcd unit test failed sometimes #312

merged 13 commits into from
Apr 27, 2024

Conversation

aofall
Copy link
Contributor

@aofall aofall commented Apr 15, 2024 •
edited
Loading

What is the purpose of the change

  1. GitHub Actions may overuse leads to long waiting times, do not setting timeout in countdown latch
  2. Bump the etcd related dependencies from 0.5.7 to 0.7.7 (old version may cause too_many_pings and blocked thread, attached log after this message)
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.dubbo.configcenter.support.etcd.EtcdDynamicConfigurationTest
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
SLF4J: Failed to load class "org.slf4j.impl.StaticMDCBinder".
SLF4J: Defaulting to no-operation MDCAdapter implementation.
SLF4J: See http://www.slf4j.org/codes.html#no_static_mdc_binder for further details.
No such logging.properties in classpath for jdk logging config!
Apr 15, 2024 8:53:01 AM org.apache.dubbo.common.logger.jdk.JdkLogger info
INFO:  [DUBBO] Dubbo Framework[1] is created, dubbo version: 3.2.9, current host: 172.18.0.1
Apr 15, 2024 8:53:01 AM org.apache.dubbo.common.logger.jdk.JdkLogger info
INFO:  [DUBBO] Creating global shared handler ..., dubbo version: 3.2.9, current host: 172.18.0.1
Apr 15, 2024 8:53:01 AM org.apache.dubbo.common.logger.jdk.JdkLogger info
INFO:  [DUBBO] Dubbo Application[1.0](unknown) is created, dubbo version: 3.2.9, current host: 172.18.0.1
Apr 15, 2024 8:53:01 AM org.apache.dubbo.common.logger.jdk.JdkLogger info
INFO:  [DUBBO] Dubbo Module[1.0.0] is created, dubbo version: 3.2.9, current host: 172.18.0.1
Apr 15, 2024 8:53:01 AM org.apache.dubbo.common.logger.jdk.JdkLogger info
INFO:  [DUBBO] Config settings: {dubbo.config.mode=STRICT, dubbo.config.ignore-duplicated-interface=false}, dubbo version: 3.2.9, current host: 172.18.0.1
Apr 15, 2024 8:53:01 AM org.apache.dubbo.common.logger.jdk.JdkLogger info
INFO:  [DUBBO] Config settings: {dubbo.config.mode=STRICT, dubbo.config.ignore-duplicated-interface=false}, dubbo version: 3.2.9, current host: 172.18.0.1
Apr 15, 2024 8:53:01 AM org.apache.dubbo.common.logger.jdk.JdkLogger info
INFO:  [DUBBO] Serialize check serializable: true, dubbo version: 3.2.9, current host: 172.18.0.1
Apr 15, 2024 8:53:01 AM org.apache.dubbo.common.logger.jdk.JdkLogger info
INFO:  [DUBBO] Read serialize allow list from jar:file:/home/runner/.m2/repository/org/apache/dubbo/dubbo-common/3.2.9/dubbo-common-3.2.9.jar!/security/serialize.allowlist, dubbo version: 3.2.9, current host: 172.18.0.1
Apr 15, 2024 8:53:01 AM org.apache.dubbo.common.logger.jdk.JdkLogger info
INFO:  [DUBBO] Read serialize blocked list from jar:file:/home/runner/.m2/repository/org/apache/dubbo/dubbo-common/3.2.9/dubbo-common-3.2.9.jar!/security/serialize.blockedlist, dubbo version: 3.2.9, current host: 172.18.0.1
Apr 15, 2024 8:55:02 AM io.grpc.netty.NettyClientHandler$2 onGoAwayReceived
WARNING: Received GOAWAY with ENHANCE_YOUR_CALM. Debug data: too_many_pings
Apr 15, 2024 8:55:02 AM io.grpc.internal.AtomicBackoff$State backoff
WARNING: Increased keepalive time nanos to 60,000,000,000
  1. Compatible the new version of jetcd

Brief changelog

Try to fix etcd unit test failed sometimes (Bump the etcd related dependencies from 0.5.7 to 0.7.7)

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before
    you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
    just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit
    in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
    exist. If the new feature or significant change is committed, please remember to add sample
    in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure
    unit-test and integration-test pass.
  • If this contribution is large, please follow
    the Software Donation Guide.

songxiaosheng
songxiaosheng approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aofall aofall marked this pull request as draft April 16, 2024 06:15
@aofall aofall marked this pull request as ready for review April 18, 2024 06:43
@aofall
Copy link
Contributor Author

aofall commented Apr 18, 2024

Looks like works, but it still needs to be observed for some time.

Don't merge before 2024-04-25, just observe one week, it maybe others potential problems

@aofall
Copy link
Contributor Author

aofall commented Apr 26, 2024

@songxiaosheng PTAL

songxiaosheng
songxiaosheng approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songxiaosheng songxiaosheng merged commit 78f87c3 into apache:master Apr 27, 2024
16 checks passed
@aofall aofall deleted the 3.2-fix-etcd3 branch November 15, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songxiaosheng songxiaosheng songxiaosheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aofall @songxiaosheng