fix: redis connection do not close and return to connection pool #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@songxiaosheng PTAL The unit test of dubbo-registry-etcd3 maybe some problem, and often causes unit tests to failed, I'll try to figure it out after this PR |
okay |
6 tasks
songxiaosheng
pushed a commit
that referenced
this pull request
Apr 26, 2024
* [Dubbo-267] Fix protobuf type lose field when deepCopy inJvmInvoker Class. (#268) * fix: dubbo-registry-dns resource leak (#308) * fix: dubbo-registry-dns memory leak && add try catch * revert junit (cherry picked from commit b3033de) * fix: redis connection do not close and return to connection pool (#311) (cherry picked from commit cbad15d) * fix test lib (#310) * fix test lib * remove useless dependency * remove useless dependency * fix bad test * TimeoutException Increase time * Revert "TimeoutException Increase time" This reverts commit 5e5bb32. * add MinaClientToServerTest disable (cherry picked from commit f38363f) * build: add Windows platform unit test for CI && add dependabot config * chore: create etcd for each unit test * chore: already check license by apache skywalking-eyes so skip rat-license check * Revert "chore: already check license by apache skywalking-eyes so skip rat-license check" This reverts commit 98d627b. * fix: rat-check failed --------- Co-authored-by: MaruHibiki <1807180752@qq.com> Co-authored-by: 王聪洋 <56506697+wcy666103@users.noreply.github.com>
songxiaosheng
pushed a commit
that referenced
this pull request
May 9, 2024
* upgrade dubbo to the 3.1 latest version in 3.1.0 branch (#293) * upgrade dubbo to the 3.1.x the latest version * fix(#207): Dubbo Redis register support select databases (cherry picked from commit 0f42ecd) * Bump version && fix test case failed (#303) * Remove dubbo-gateway-common module because the class ByteAccessor since dubbo 3.2.0, but this branch(3.1.0) based on the dubbo 3.1.x * Bump the extensions version to 3.1.0 && revision the pom.xml * Adjust test ci workspace * add GitHub Actions workflow file * add GitHub Actions workflow file * build: add some ignore file for license check * chore: fix missed or incorrect ASF license * fix multi os prepare test failed * fix test case failed * try to fix conformance test failed * try to fix conformance test failed * fix ci build failed * Cherry-pick bug fix from master into 3.1.0 branch (#334) * [Dubbo-267] Fix protobuf type lose field when deepCopy inJvmInvoker Class. (#268) * fix: dubbo-registry-dns resource leak (#308) * fix: dubbo-registry-dns memory leak && add try catch * revert junit (cherry picked from commit b3033de) * fix: redis connection do not close and return to connection pool (#311) (cherry picked from commit cbad15d) * fix test lib (#310) * fix test lib * remove useless dependency * remove useless dependency * fix bad test * TimeoutException Increase time * Revert "TimeoutException Increase time" This reverts commit 5e5bb32. * add MinaClientToServerTest disable (cherry picked from commit f38363f) * build: add Windows platform unit test for CI && add dependabot config * chore: create etcd for each unit test * chore: already check license by apache skywalking-eyes so skip rat-license check * Revert "chore: already check license by apache skywalking-eyes so skip rat-license check" This reverts commit 98d627b. * fix: rat-check failed --------- Co-authored-by: MaruHibiki <1807180752@qq.com> Co-authored-by: 王聪洋 <56506697+wcy666103@users.noreply.github.com> * update: compatible dubbo 3.0.x Remove dubbo-registry-dns because ReflectionBasedServiceDiscovery since dubbo 3.1 * ci: adjust build tools use dubbo 3.0 * ci: Upload coverage to Codecov --------- Co-authored-by: MaruHibiki <1807180752@qq.com> Co-authored-by: 王聪洋 <56506697+wcy666103@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
try to fix #73 and apache/dubbo#1677
Get Jedis from pool don't need to close connection after using, just return the connection to pool that we can reused the connection in next time.
Brief changelog
redis connection do not close and return to connection pool
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
just this issue, without pulling in other changes - one PR resolves one issue.
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commitin the pull request should have a meaningful subject line and body.
exist. If the new feature or significant change is committed, please remember to add sample
in dubbo samples project.
mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sureunit-test and integration-test pass.
the Software Donation Guide.