Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ rpc rocketmq upgrade dubbo 3.2 #262

Merged
merged 5 commits into from
Dec 24, 2023

Conversation

songxiaosheng
Copy link
Member

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before
    you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
    just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit
    in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
    exist. If the new feature or significant change is committed, please remember to add sample
    in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure
    unit-test and integration-test pass.
  • If this contribution is large, please follow
    the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (28b5586) 25.13% compared to head (1ff6708) 25.07%.

Additional details and impacted files
@@             Coverage Diff              @@
##              3.2.0     #262      +/-   ##
============================================
- Coverage     25.13%   25.07%   -0.06%     
+ Complexity     1004     1002       -2     
============================================
  Files           284      284              
  Lines         13134    13134              
  Branches       1701     1701              
============================================
- Hits           3301     3294       -7     
- Misses         9496     9502       +6     
- Partials        337      338       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@songxiaosheng songxiaosheng merged commit 07416c0 into apache:3.2.0 Dec 24, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants