Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serialization module adapter to 3.2 #259

Merged
merged 16 commits into from
Dec 22, 2023

Conversation

xixingya
Copy link
Contributor

What is the purpose of the change

serialization module adapter to 3.2

Brief changelog

dubbo-serialization

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before
    you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
    just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit
    in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
    exist. If the new feature or significant change is committed, please remember to add sample
    in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure
    unit-test and integration-test pass.
  • If this contribution is large, please follow
    the Software Donation Guide.

@xixingya xixingya changed the base branch from master to 3.2.0 December 20, 2023 11:22
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (db84301) 30.87% compared to head (aec55f4) 25.05%.
Report is 41 commits behind head on 3.2.0.

Additional details and impacted files
@@             Coverage Diff              @@
##              3.2.0     #259      +/-   ##
============================================
- Coverage     30.87%   25.05%   -5.83%     
- Complexity      485      999     +514     
============================================
  Files           161      283     +122     
  Lines          5483    13127    +7644     
  Branches        667     1701    +1034     
============================================
+ Hits           1693     3289    +1596     
- Misses         3602     9502    +5900     
- Partials        188      336     +148     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songxiaosheng songxiaosheng merged commit c828581 into apache:3.2.0 Dec 22, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants