configcenter etcd support dubbo3.2 #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songxiaosheng
requested changes
Nov 28, 2023
| @@ -67,7 +66,7 @@ | |||
| import static java.nio.charset.StandardCharsets.UTF_8; | |||
| import static org.apache.dubbo.remoting.etcd.Constants.SESSION_TIMEOUT_KEY; | |||
|
|
|||
| @Disabled | |||
| //@Disabled | |||
There was a problem hiding this comment.
please don't remove annotation Disabled
| @@ -54,7 +54,7 @@ | |||
| import static org.mockito.Mockito.doAnswer; | |||
| import static org.mockito.Mockito.spy; | |||
|
|
|||
| @Disabled | |||
| //@Disabled | |||
There was a problem hiding this comment.
please don't remove annotation Disabled
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.2.0 #243 +/- ##
============================================
+ Coverage 33.26% 33.99% +0.72%
- Complexity 511 519 +8
============================================
Files 161 161
Lines 5483 5483
Branches 667 667
============================================
+ Hits 1824 1864 +40
+ Misses 3451 3410 -41
- Partials 208 209 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
XXXXX
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
just this issue, without pulling in other changes - one PR resolves one issue.
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commitin the pull request should have a meaningful subject line and body.
exist. If the new feature or significant change is committed, please remember to add sample
in dubbo samples project.
mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sureunit-test and integration-test pass.
the Software Donation Guide.