Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 upgrade readme #235

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Conversation

songxiaosheng
Copy link
Member

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before
    you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
    just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit
    in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
    exist. If the new feature or significant change is committed, please remember to add sample
    in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure
    unit-test and integration-test pass.
  • If this contribution is large, please follow
    the Software Donation Guide.

@codecov-commenter
Copy link

Codecov Report

Merging #235 (4fe5a63) into master (2752e83) will decrease coverage by 0.17%.
The diff coverage is n/a.

❗ Current head 4fe5a63 differs from pull request most recent head dd9868e. Consider uploading reports for the commit dd9868e to get more accurate results

@@             Coverage Diff              @@
##             master     #235      +/-   ##
============================================
- Coverage     34.04%   33.87%   -0.17%     
+ Complexity      506      505       -1     
============================================
  Files           156      156              
  Lines          5326     5326              
  Branches        662      661       -1     
============================================
- Hits           1813     1804       -9     
- Misses         3314     3324      +10     
+ Partials        199      198       -1     

see 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@songxiaosheng songxiaosheng merged commit 7a90eb3 into apache:master Nov 10, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants