[tag subnets] add tag by subnets for near-rpc #216

carlvine500 · 2023-08-01T10:25:03Z

What is the purpose of the change

most people depoy service in three zone for HA , we expect service rpc in same zone :

tag-subnets:

cn|shanghai|a:
- 172.37.66.0/24 #zone=cn-shanghai-a
- 172.37.67.0/24 #zone=cn-shanghai-a
cn|shanghai|b:
- 172.37.68.0/24 #zone=cn-shanghai-b
cn|shanghai|c:
- 172.37.69.0/24 #zone=cn-shanghai-c

some company's service are in a big zone , we expect service rpc in same cell :

tag-subnets:

cn|shanghai|a|cell-1:
- 172.31.35.0/24 #zone=cn-shanghai-a
cn|shanghai|a|cell-2:
- 172.31.36.0/24 #zone=cn-shanghai-a
cn|shanghai|a|cell-3:
- 172.31.37.0/24 #zone=cn-shanghai-a

some company's service are in serveral city, we expect service prefer rpc in same zone , and rpc special service across zone( such as stock quantity service):

tag-subnets:

cn|shanghai|a:
- 172.37.66.0/24 #zone=cn-shanghai-a
cn|hangzhou|b:
- 172.37.67.0/24 #zone=cn-hangzhou-b
cn|shenzhen|c:
- 172.37.68.0/24 #zone=cn-shenzhen-c
"":
- 172.37.69.0/24 #zone=cn-shanghai-d, as common service

Brief changelog

add a configuration in configcenter: /dubbo/config/dubbo/tag.subnets , content is :

cn|shanghai|a:
- 172.37.66.0/24 #zone=cn-shanghai-a
cn|shanghai|b:
- 172.37.68.0/24 #zone=cn-shanghai-b
cn|shanghai|c:
- 172.37.69.0/24 #zone=cn-shanghai-c

ServiceConfig.java will add a tag by subnet, such as :
service on host 172.37.66.1 will add a dubbo.tag=cn|shanghai|a
and then service in cn-shanghai-a will rpc same zone
pull request tag support multi level dubbo#12673 will help to prefer rpc with long tag-level, for example:
consumer rpc tag=cn|shanghai|a
prefer1: service tag=cn|shanghai|a
prefer2: service tag=cn|shanghai
prefer3: service tag=cn
prefer4: service tag=""

Verifying this change

Checklist

Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
Each commit in the pull request should have a meaningful subject line and body.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
Add some description to dubbo-website project if you are requesting to add a feature.
GitHub Actions works fine on your own branch.
If this contribution is large, please follow the Software Donation Guide.

codecov-commenter · 2023-08-01T10:32:51Z

Codecov Report

Merging #216 (95285ca) into master (abd907b) will increase coverage by 0.19%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #216      +/-   ##
============================================
+ Coverage     33.63%   33.83%   +0.19%     
- Complexity      497      505       +8     
============================================
  Files           154      156       +2     
  Lines          5280     5326      +46     
  Branches        655      662       +7     
============================================
+ Hits           1776     1802      +26     
- Misses         3306     3326      +20     
  Partials        198      198

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

AlbumenJ · 2023-08-09T06:57:49Z

dubbo-tag-extensions/dubbo-tag-subnets/pom.xml

+
+    <properties>
+        <javax.ws.rs.version>2.1</javax.ws.rs.version>
+        <argline>-Dnetwork_interface_denylist=docker0</argline>


Why add this?

Why add this?

Thanks for your review , I will remove these redundant properties .

remove redundant properties.

AlbumenJ · 2023-08-10T02:57:29Z

dubbo-tag-extensions/dubbo-tag-subnets/pom.xml

+        <dependency>
+            <groupId>org.testcontainers</groupId>
+            <artifactId>testcontainers</artifactId>
+            <scope>test</scope>


Is this dependency necessary?

Is this dependency necessary?

like most of the extensions pom.xml , import org.junit.jupiter in testcontainers . can I import jupiter instead of testcontainers ?

sure

ok , test depend on junit-jupiter-engine now .

@AlbumenJ please check it again .

AlbumenJ · 2023-08-14T07:40:36Z

dubbo-tag-extensions/dubbo-tag-subnets/pom.xml

+    <version>1.0.2-SNAPSHOT</version>
+    <artifactId>dubbo-tag-subnets</artifactId>
+    <name>${project.artifactId}</name>
+    <description>The SOFARegistry module of Dubbo project</description>


Is this typo?

Others LGTM

Is this typo?

Others LGTM

sorry, I forget to change description, it's ok now .

tag subnets

55b69b5

carlvine500 mentioned this pull request Aug 1, 2023

rpc in same zone or rpc in same cell apache/dubbo#12764

Closed

8 tasks

carlvine500 changed the title ~~tag subnets~~ [tag subnets] add tag by subnets for near-rpc Aug 1, 2023

change some protected field to private final;remote unused import

7e80079

AlbumenJ requested changes Aug 9, 2023

View reviewed changes

Update pom.xml

c6083fb

remove redundant properties.

carlvine500 requested a review from AlbumenJ August 10, 2023 00:52

AlbumenJ requested changes Aug 10, 2023

View reviewed changes

carlvine500 requested a review from AlbumenJ August 10, 2023 05:41

carlvine500 added 2 commits August 10, 2023 17:57

merge master

95285ca

add dependency junit-jupiter-engine

0a123b2

AlbumenJ requested changes Aug 14, 2023

View reviewed changes

change description in pom.xml

61c3ac3

AlbumenJ approved these changes Aug 14, 2023

View reviewed changes

AlbumenJ merged commit a6e6eb1 into apache:master Aug 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tag subnets] add tag by subnets for near-rpc #216

[tag subnets] add tag by subnets for near-rpc #216

carlvine500 commented Aug 1, 2023 •

edited

Loading

codecov-commenter commented Aug 1, 2023 •

edited

Loading

AlbumenJ Aug 9, 2023

carlvine500 Aug 10, 2023

AlbumenJ Aug 10, 2023

carlvine500 Aug 10, 2023

AlbumenJ Aug 11, 2023

carlvine500 Aug 11, 2023 •

edited

Loading

carlvine500 Aug 11, 2023

AlbumenJ Aug 14, 2023

carlvine500 Aug 14, 2023

[tag subnets] add tag by subnets for near-rpc #216

[tag subnets] add tag by subnets for near-rpc #216

Conversation

carlvine500 commented Aug 1, 2023 • edited Loading

What is the purpose of the change

most people depoy service in three zone for HA , we expect service rpc in same zone :

some company's service are in a big zone , we expect service rpc in same cell :

some company's service are in serveral city, we expect service prefer rpc in same zone , and rpc special service across zone( such as stock quantity service):

Brief changelog

Verifying this change

Checklist

codecov-commenter commented Aug 1, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlvine500 Aug 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlvine500 commented Aug 1, 2023 •

edited

Loading

codecov-commenter commented Aug 1, 2023 •

edited

Loading

carlvine500 Aug 11, 2023 •

edited

Loading