Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:support polaris circuitbreaker ability #212

Merged
merged 6 commits into from
Jul 13, 2023
Merged

feat:support polaris circuitbreaker ability #212

merged 6 commits into from
Jul 13, 2023

Conversation

chuntaojun
Copy link
Contributor

@chuntaojun chuntaojun commented Jun 26, 2023 •
edited
Loading

What is the purpose of the change

feat issue #213

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before
    you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
    just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit
    in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
    exist. If the new feature or significant change is committed, please remember to add sample
    in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure
    unit-test and integration-test pass.
  • If this contribution is large, please follow
    the Software Donation Guide.

songxiaosheng
songxiaosheng requested changes Jun 27, 2023
View reviewed changes
Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove unused import

2023-06-26T13:48:39.0392953Z [ERROR] /home/runner/work/dubbo-spi-extensions/dubbo-spi-extensions/dubbo-spi-extensions/dubbo-registry-extensions/dubbo-registry-polaris/src/main/java/org/apache/dubbo/registry/polaris/PolarisRegistry.java:24:8: Unused import - com.tencent.polaris.common.registry.ConvertUtils. [UnusedImports]
2023-06-26T13:48:39.0397309Z Audit done.
2023-06-26T13:48:39.0407603Z [INFO] There is 1 error reported by Checkstyle 8.41 with ./codestyle/checkstyle.xml ruleset.
2023-06-26T13:48:39.0442393Z [ERROR] src/main/java/org/apache/dubbo/registry/polaris/PolarisRegistry.java:[24,8] (imports) UnusedImports: Unused import - com.tencent.polaris.common.registry.ConvertUtils.

@chuntaojun
Copy link
Contributor Author

please remove unused import

2023-06-26T13:48:39.0392953Z [ERROR] /home/runner/work/dubbo-spi-extensions/dubbo-spi-extensions/dubbo-spi-extensions/dubbo-registry-extensions/dubbo-registry-polaris/src/main/java/org/apache/dubbo/registry/polaris/PolarisRegistry.java:24:8: Unused import - com.tencent.polaris.common.registry.ConvertUtils. [UnusedImports] 2023-06-26T13:48:39.0397309Z Audit done. 2023-06-26T13:48:39.0407603Z [INFO] There is 1 error reported by Checkstyle 8.41 with ./codestyle/checkstyle.xml ruleset. 2023-06-26T13:48:39.0442393Z [ERROR] src/main/java/org/apache/dubbo/registry/polaris/PolarisRegistry.java:[24,8] (imports) UnusedImports: Unused import - com.tencent.polaris.common.registry.ConvertUtils.

already fix

@chuntaojun chuntaojun marked this pull request as draft June 27, 2023 10:40
@codecov-commenter
Copy link

Codecov Report

Merging #212 (f2ac2d0) into master (69d5a6e) will increase coverage by 0.84%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #212      +/-   ##
============================================
+ Coverage     33.70%   34.55%   +0.84%     
- Complexity      492      519      +27     
============================================
  Files           147      154       +7     
  Lines          5228     5470     +242     
  Branches        655      685      +30     
============================================
+ Hits           1762     1890     +128     
- Misses         3270     3356      +86     
- Partials        196      224      +28

see 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@songxiaosheng songxiaosheng marked this pull request as ready for review June 28, 2023 12:16
@AlbumenJ AlbumenJ merged commit 644960b into apache:master Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songxiaosheng songxiaosheng songxiaosheng requested changes

@AlbumenJ AlbumenJ AlbumenJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chuntaojun @codecov-commenter @AlbumenJ @songxiaosheng