[Dubbo-SPECIFY-ADDRESS] fix npe when zk push url #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbumenJ
approved these changes
Nov 12, 2022
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
============================================
- Coverage 39.67% 33.52% -6.16%
- Complexity 510 513 +3
============================================
Files 138 152 +14
Lines 4492 5349 +857
Branches 553 660 +107
============================================
+ Hits 1782 1793 +11
- Misses 2516 3360 +844
- Partials 194 196 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
The test found that there was a problem with the previous one. We need to exclude the type of InstanceAddressURL. It will throw an exception when getUrlAddress. Now the dynamic change of ip can work normally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: x-shadow-man 1494445739@qq.com
What is the purpose of the change
bugfix of issue #166
Brief changelog
add npe judge, if null, reconstruct PathURLAddress obj
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
just this issue, without pulling in other changes - one PR resolves one issue.
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commitin the pull request should have a meaningful subject line and body.
exist. If the new feature or significant change is committed, please remember to add sample
in dubbo samples project.
mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sureunit-test and integration-test pass.
the Software Donation Guide.