Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tag router ut #9630

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Add tag router ut #9630

merged 1 commit into from
Jan 26, 2022

Conversation

CrazyHZM
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2022 •
edited
Loading

Codecov Report

Merging #9630 (1919fc9) into 3.0 (5672670) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #9630      +/-   ##
============================================
+ Coverage     65.50%   65.72%   +0.21%     
- Complexity      296      297       +1     
============================================
  Files          1191     1191              
  Lines         51989    51992       +3     
  Branches       7887     7889       +2     
============================================
+ Hits          34055    34170     +115     
+ Misses        14258    14139     -119     
- Partials       3676     3683       +7
Impacted Files Coverage Δ
...nt/metadata/ServiceInstanceHostPortCustomizer.java 65.78% <0.00%> (-21.06%) ⬇️
.../remoting/transport/netty4/NettyServerHandler.java 58.13% <0.00%> (-9.31%) ⬇️
...ubbo/registry/client/AbstractServiceDiscovery.java 86.08% <0.00%> (-3.48%) ⬇️
.../dubbo/registry/integration/RegistryDirectory.java 48.48% <0.00%> (-0.76%) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 82.18% <0.00%> (-0.34%) ⬇️
...ting/zookeeper/curator/CuratorZookeeperClient.java 69.23% <0.00%> (ø)
...ache/dubbo/config/utils/ConfigValidationUtils.java 77.19% <0.00%> (+0.13%) ⬆️
...e/dubbo/registry/integration/RegistryProtocol.java 59.45% <0.00%> (+0.27%) ⬆️
...ubbo/config/deploy/DefaultApplicationDeployer.java 73.00% <0.00%> (+0.40%) ⬆️
...in/java/org/apache/dubbo/config/ServiceConfig.java 73.17% <0.00%> (+0.54%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5672670...1919fc9. Read the comment docs.

@CrazyHZM CrazyHZM merged commit 2ab9698 into apache:3.0 Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CrazyHZM @codecov-commenter