Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Add Router Snapshot Print Support #9517

Merged
merged 5 commits into from
Jan 5, 2022
Merged

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

  • Add QoS Router Snapshot Print
  • Add Router Snapshot Print Filter for service level
  • Add QoS Enable service level Router Snapshot Print

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Sorry, something went wrong.

@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2021

Codecov Report

Merging #9517 (5867c27) into 3.0 (798840e) will increase coverage by 0.43%.
The diff coverage is 32.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #9517      +/-   ##
============================================
+ Coverage     65.08%   65.52%   +0.43%     
+ Complexity      355      296      -59     
============================================
  Files          1218     1188      -30     
  Lines         52648    51758     -890     
  Branches       7855     7818      -37     
============================================
- Hits          34268    33915     -353     
+ Misses        14736    14177     -559     
- Partials       3644     3666      +22     
Impacted Files Coverage Δ
.../rpc/cluster/router/mock/MockInvokersSelector.java 69.23% <0.00%> (-7.92%) ⬇️
.../rpc/cluster/router/state/AbstractStateRouter.java 75.00% <0.00%> (-4.60%) ⬇️
...apache/dubbo/rpc/cluster/router/state/BitList.java 78.63% <0.00%> (-5.01%) ⬇️
.../rpc/cluster/router/state/RouterGroupingState.java 0.00% <0.00%> (ø)
...he/dubbo/rpc/cluster/router/state/StateRouter.java 100.00% <ø> (ø)
...ubbo/rpc/cluster/router/state/TailStateRouter.java 33.33% <0.00%> (-4.17%) ⬇️
...apache/dubbo/common/constants/CommonConstants.java 100.00% <ø> (ø)
...e/dubbo/qos/command/impl/EnableDetailProfiler.java 40.00% <0.00%> (ø)
...ache/dubbo/qos/command/impl/GetRouterSnapshot.java 10.71% <10.71%> (ø)
.../dubbo/qos/command/impl/DisableRouterSnapshot.java 23.52% <23.52%> (ø)
... and 255 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32a083c...5867c27. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 4cc3b28 into apache:3.0 Jan 5, 2022
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request Jan 24, 2022
* [3.0] Add Router Snapshot

* [3.0] Add ut

* [3.0] Add RouterSnapshotFilter

* [3.0] Add recent log

* opt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants