Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fastjson2 Support #10166

Merged
merged 40 commits into from
Jul 15, 2022
Merged

Fastjson2 Support #10166

merged 40 commits into from
Jul 15, 2022

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ AlbumenJ changed the title Fastjson2 Support [WIP] Fastjson2 Support Jun 15, 2022
@AlbumenJ AlbumenJ marked this pull request as ready for review June 15, 2022 12:11
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022 •
edited
Loading

Codecov Report

Merging #10166 (0d1a2c3) into 3.1 (61beabd) will increase coverage by 0.02%.
The diff coverage is 65.16%.

@@             Coverage Diff              @@
##                3.1   #10166      +/-   ##
============================================
+ Coverage     65.60%   65.62%   +0.02%     
+ Complexity      297      296       -1     
============================================
  Files          1234     1240       +6     
  Lines         53809    53957     +148     
  Branches       8119     8130      +11     
============================================
+ Hits          35301    35410     +109     
- Misses        14678    14709      +31     
- Partials       3830     3838       +8
Impacted Files Coverage Δ
...main/java/org/apache/dubbo/remoting/Constants.java 100.00% <ø> (ø)
...mon/serialize/fastjson2/FastJson2ObjectOutput.java 56.25% <56.25%> (ø)
...erialize/support/DefaultSerializationSelector.java 60.00% <60.00%> (ø)
...in/java/org/apache/dubbo/rpc/model/ScopeModel.java 79.09% <61.53%> (-2.36%) ⬇️
...mmon/serialize/fastjson2/FastJson2ObjectInput.java 62.50% <62.50%> (ø)
...n/serialize/fastjson2/Fastjson2CreatorManager.java 66.66% <66.66%> (ø)
...on/serialize/fastjson2/FastJson2Serialization.java 85.71% <85.71%> (ø)
.../apache/dubbo/remoting/transport/CodecSupport.java 83.33% <100.00%> (+3.03%) ⬆️
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 70.37% <100.00%> (ø)
...he/dubbo/rpc/protocol/dubbo/DubboCodecSupport.java 85.71% <100.00%> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61beabd...0d1a2c3. Read the comment docs.

@wangchengming666 wangchengming666 mentioned this pull request Jun 21, 2022
Closed
@AlbumenJ AlbumenJ changed the base branch from 3.0 to 3.1 July 1, 2022 03:25
@AlbumenJ AlbumenJ changed the title [WIP] Fastjson2 Support Fastjson2 Support Jul 1, 2022
@AlbumenJ AlbumenJ requested review from chickenlj and CrazyHZM July 4, 2022 01:53
CrazyHZM
CrazyHZM approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chickenlj chickenlj merged commit f1af604 into apache:3.1 Jul 15, 2022
@AlbumenJ AlbumenJ added this to the 3.1.0 milestone Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrazyHZM CrazyHZM CrazyHZM approved these changes

@chickenlj chickenlj Awaiting requested review from chickenlj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AlbumenJ @codecov-commenter @CrazyHZM @chickenlj