-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve](schema-change) support nested type with varchar type to support length growing #46639
[improve](schema-change) support nested type with varchar type to support length growing #46639
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 32732 ms
|
TPC-DS: Total hot run time: 195928 ms
|
ClickBench: Total hot run time: 31.5 s
|
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java
Outdated
Show resolved
Hide resolved
regression-test/suites/schema_change_p0/test_varchar_sc_in_complex.groovy
Show resolved
Hide resolved
regression-test/suites/schema_change_p0/test_varchar_sc_in_complex.groovy
Show resolved
Hide resolved
} | ||
|
||
|
||
sql """ alter table ${tableName} modify column c_a array<varchar(20)> """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plz add a case as such like:
alter table ${tableName} modify column c_a array<varchar(20)> after c_s
cuz modify type
+reorder
will do link schema change rather than light schema change
we shall test this case additionaly
regression-test/suites/schema_change_p0/test_varchar_sc_in_complex.groovy
Show resolved
Hide resolved
regression-test/suites/schema_change_p0/test_varchar_sc_in_complex.groovy
Show resolved
Hide resolved
run buildall |
TPC-H: Total hot run time: 32793 ms
|
TPC-DS: Total hot run time: 195459 ms
|
ClickBench: Total hot run time: 32.3 s
|
run buildall |
TPC-H: Total hot run time: 32535 ms
|
TPC-DS: Total hot run time: 195776 ms
|
ClickBench: Total hot run time: 31.75 s
|
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java
Outdated
Show resolved
Hide resolved
run buildall |
TPC-DS: Total hot run time: 187509 ms
|
ClickBench: Total hot run time: 31.14 s
|
run buildall |
TPC-H: Total hot run time: 32692 ms
|
TPC-DS: Total hot run time: 194958 ms
|
ClickBench: Total hot run time: 31.68 s
|
run buildall |
TPC-H: Total hot run time: 32900 ms
|
TPC-DS: Total hot run time: 188507 ms
|
ClickBench: Total hot run time: 30.54 s
|
run buildall |
TPC-H: Total hot run time: 32778 ms
|
TPC-DS: Total hot run time: 196116 ms
|
ClickBench: Total hot run time: 31.29 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…port length growing (#46639) The array|map|struct schema-change behavior supports moditfy to change the length of the varchar type in the current column type. before ``` mysql> alter table t_sc MODIFY COLUMN s struct<col:varchar(20)>; ERROR 1105 (HY000): errCode = 2, detailMessage = Can not change struct<col:varchar(10)> to `__doris_shadow_s` struct<col:varchar(20)> NULL ```
What problem does this PR solve?
The array|map|struct schema-change behavior supports moditfy to change the length of the varchar type in the current column type.
before
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)