Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor](exec) Remove the unless code in BE #46122

Merged
merged 1 commit into from
Dec 28, 2024
Merged

[Refactor](exec) Remove the unless code in BE #46122

merged 1 commit into from
Dec 28, 2024

Conversation

HappenLee
Copy link
Contributor

What problem does this PR solve?

Remove the unless code:

OldCount,  TransformerToStringTwoArgument ,  be/src/util/type_traits.h

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 28, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@HappenLee
Copy link
Contributor Author

run buildall

1 similar comment
@HappenLee
Copy link
Contributor Author

run buildall

@HappenLee
Copy link
Contributor Author

run buildall

@HappenLee
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32451 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 089d5c73fb7a7a9642e4d194b975de0d6e00ecb2, data reload: false

------ Round 1 ----------------------------------
q1	17578	6137	6017	6017
q2	2039	303	186	186
q3	10511	1208	759	759
q4	10184	863	421	421
q5	7518	2162	1943	1943
q6	205	181	148	148
q7	882	737	616	616
q8	9243	1343	1174	1174
q9	5374	4897	4888	4888
q10	6720	2306	1849	1849
q11	492	275	250	250
q12	343	358	217	217
q13	17754	3561	2885	2885
q14	240	244	214	214
q15	560	491	492	491
q16	624	627	597	597
q17	569	854	337	337
q18	6996	6500	6450	6450
q19	1435	966	538	538
q20	312	319	193	193
q21	2843	2176	1964	1964
q22	359	337	314	314
Total cold run time: 102781 ms
Total hot run time: 32451 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6257	6220	6239	6220
q2	230	332	227	227
q3	2218	2572	2328	2328
q4	1377	1832	1410	1410
q5	4330	4697	4722	4697
q6	188	180	146	146
q7	2061	1941	1852	1852
q8	2648	2835	2703	2703
q9	7385	7262	7319	7262
q10	3097	3356	2875	2875
q11	587	496	482	482
q12	656	711	585	585
q13	3432	3761	3128	3128
q14	297	316	270	270
q15	566	517	522	517
q16	658	688	639	639
q17	1232	1755	1257	1257
q18	7749	7389	7280	7280
q19	815	1240	1032	1032
q20	1992	2100	1959	1959
q21	5633	5330	4881	4881
q22	622	627	580	580
Total cold run time: 54030 ms
Total hot run time: 52330 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.90% (10121/26015)
Line Coverage: 29.90% (85533/286089)
Region Coverage: 29.02% (43713/150608)
Branch Coverage: 25.56% (22301/87256)
Coverage Report: http://coverage.selectdb-in.cc/coverage/089d5c73fb7a7a9642e4d194b975de0d6e00ecb2_089d5c73fb7a7a9642e4d194b975de0d6e00ecb2/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 196469 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 089d5c73fb7a7a9642e4d194b975de0d6e00ecb2, data reload: false

query1	1299	940	925	925
query2	6484	2319	2374	2319
query3	11109	4805	4845	4805
query4	32957	23722	23310	23310
query5	4043	585	442	442
query6	278	200	184	184
query7	3999	491	300	300
query8	298	257	258	257
query9	9403	2737	2710	2710
query10	461	318	261	261
query11	17959	15485	15119	15119
query12	157	110	105	105
query13	1605	546	409	409
query14	10090	6798	6901	6798
query15	258	217	191	191
query16	7529	640	414	414
query17	1527	738	561	561
query18	2006	376	321	321
query19	196	187	155	155
query20	123	114	117	114
query21	209	131	111	111
query22	4731	4721	4739	4721
query23	34609	33833	34419	33833
query24	6586	2347	2265	2265
query25	468	454	393	393
query26	719	264	153	153
query27	2477	468	370	370
query28	6121	2502	2468	2468
query29	542	570	430	430
query30	206	180	147	147
query31	974	962	827	827
query32	83	64	57	57
query33	491	356	307	307
query34	776	864	513	513
query35	795	869	758	758
query36	1044	1063	999	999
query37	119	101	72	72
query38	4303	4178	4171	4171
query39	1537	1505	1458	1458
query40	204	116	101	101
query41	47	42	44	42
query42	116	103	102	102
query43	520	528	498	498
query44	1388	825	826	825
query45	180	177	171	171
query46	861	1061	652	652
query47	1998	2023	1964	1964
query48	380	402	320	320
query49	715	484	384	384
query50	643	670	411	411
query51	7248	7324	7167	7167
query52	118	102	94	94
query53	226	259	183	183
query54	473	496	411	411
query55	88	85	82	82
query56	302	283	259	259
query57	1216	1283	1201	1201
query58	252	230	244	230
query59	3082	3293	3137	3137
query60	271	264	254	254
query61	109	107	108	107
query62	877	807	767	767
query63	229	189	194	189
query64	3743	1032	656	656
query65	3333	3246	3274	3246
query66	818	431	309	309
query67	16694	15914	15591	15591
query68	10253	751	506	506
query69	485	299	246	246
query70	1203	1159	1116	1116
query71	443	290	245	245
query72	5874	3882	3778	3778
query73	1268	754	367	367
query74	9837	9315	9136	9136
query75	4585	3149	2671	2671
query76	5597	1197	771	771
query77	1034	362	277	277
query78	10693	10266	9332	9332
query79	5770	867	583	583
query80	730	526	429	429
query81	489	259	226	226
query82	667	157	115	115
query83	193	164	140	140
query84	277	101	72	72
query85	892	358	302	302
query86	343	295	259	259
query87	4623	4522	4317	4317
query88	4354	2196	2222	2196
query89	448	325	287	287
query90	1964	185	183	183
query91	152	137	104	104
query92	64	55	52	52
query93	2771	816	514	514
query94	666	398	288	288
query95	334	268	242	242
query96	488	615	284	284
query97	2783	2796	2666	2666
query98	231	195	194	194
query99	1705	1594	1465	1465
Total cold run time: 305918 ms
Total hot run time: 196469 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.72 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 089d5c73fb7a7a9642e4d194b975de0d6e00ecb2, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.04
query3	0.24	0.07	0.06
query4	1.62	0.10	0.10
query5	0.41	0.43	0.41
query6	1.16	0.68	0.69
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.59	0.50	0.50
query10	0.57	0.57	0.56
query11	0.14	0.10	0.10
query12	0.14	0.12	0.10
query13	0.63	0.61	0.62
query14	2.74	2.82	2.80
query15	0.92	0.85	0.85
query16	0.40	0.39	0.37
query17	1.09	1.01	1.10
query18	0.23	0.22	0.20
query19	1.95	1.87	2.01
query20	0.01	0.01	0.02
query21	15.39	0.96	0.59
query22	0.74	0.82	0.72
query23	15.22	1.50	0.55
query24	2.94	1.71	1.93
query25	0.11	0.15	0.14
query26	0.29	0.15	0.14
query27	0.07	0.04	0.05
query28	14.65	1.64	1.08
query29	12.58	4.10	3.31
query30	0.25	0.09	0.06
query31	2.83	0.61	0.40
query32	3.23	0.58	0.49
query33	3.14	3.15	3.17
query34	16.50	5.23	4.58
query35	4.59	4.59	4.64
query36	0.70	0.50	0.49
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.03
query40	0.18	0.14	0.14
query41	0.07	0.03	0.03
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.72 s
Total hot run time: 32.72 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@HappenLee HappenLee merged commit 2b20512 into apache:master Dec 28, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HappenLee @Thearas @doris-robot @BiteTheDDDDt @yiguolei