Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix](paimon)Get the file format by file name #41020

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

wuwenchi
Copy link
Contributor

Proposed changes

When file.format is not specified for the paimon table, the default file format will be used. In 0.8, the default format was orc, and in 0.9, it was changed to parquet.
Therefore, when there was no file.format and the paimon table was in version 0.9, Doris mistakenly used the orc reader to read the parquet file.

Now modify it to directly determine the file format based on the file name, and then use the corresponding reader.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@wuwenchi
Copy link
Contributor Author

run buildall

@wuwenchi
Copy link
Contributor Author

run buildall

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 23, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@suxiaogang223
Copy link
Contributor

LGTM

@morningman morningman merged commit fb9d85e into apache:master Sep 24, 2024
25 of 28 checks passed
wuwenchi added a commit to wuwenchi/doris_new that referenced this pull request Sep 27, 2024
## Proposed changes

When `file.format` is not specified for the paimon table, the default
file format will be used. In 0.8, the default format was `orc`, and in
0.9, it was changed to `parquet`.
Therefore, when there was no `file.format` and the paimon table was in
version 0.9, Doris mistakenly used the orc reader to read the parquet
file.

Now modify it to directly determine the file format based on the file
name, and then use the corresponding reader.
gavinchou pushed a commit that referenced this pull request Sep 28, 2024
## Proposed changes

When `file.format` is not specified for the paimon table, the default
file format will be used. In 0.8, the default format was `orc`, and in
0.9, it was changed to `parquet`.
Therefore, when there was no `file.format` and the paimon table was in
version 0.9, Doris mistakenly used the orc reader to read the parquet
file.

Now modify it to directly determine the file format based on the file
name, and then use the corresponding reader.
wuwenchi added a commit to wuwenchi/doris_new that referenced this pull request Sep 30, 2024
## Proposed changes

When `file.format` is not specified for the paimon table, the default
file format will be used. In 0.8, the default format was `orc`, and in
0.9, it was changed to `parquet`.
Therefore, when there was no `file.format` and the paimon table was in
version 0.9, Doris mistakenly used the orc reader to read the parquet
file.

Now modify it to directly determine the file format based on the file
name, and then use the corresponding reader.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.2-merged p0_b reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants