Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](cloud) Fix possible incorrect merged tablet stats while iterating detached tablet stats #40494

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

gavinchou
Copy link
Contributor

Previous impl. of get_detached_tablet_stats() may miss some detached KVs or tablet stats due to KV iterating paging (RangeGetIterator.more() == true), which leads to zero detached stats and produce buggy data size report to FE.

Previous impl. of `get_detached_tablet_stats()` may miss some detached
KVs or tablet stats due to KV iterating paging (`RangeGetIterator.more() == true`),
which leads to zero detached stats and produce buggy data size report to FE.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@gavinchou
Copy link
Contributor Author

run buildall

@gavinchou
Copy link
Contributor Author

run buildall

@gavinchou gavinchou added the p0_c label Sep 8, 2024
@gavinchou gavinchou changed the title [fix](cloud) Fix incorrect merged tablet stats [fix](cloud) Fix possible incorrect merged tablet stats while iterating detached tablet stats Sep 8, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 10, 2024
@gavinchou
Copy link
Contributor Author

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit fe4efdd into apache:master Sep 11, 2024
24 of 26 checks passed
dataroaring pushed a commit that referenced this pull request Sep 11, 2024
…ng detached tablet stats (#40494)

Previous impl. of `get_detached_tablet_stats()` may miss some detached
KVs or tablet stats due to KV iterating paging (`RangeGetIterator.more()
== true`), which leads to zero detached stats and produce buggy data
size report to FE.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.2-merged p0_c reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants