Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug](function) fix encryption_function return wrong result at const column #40201

Merged
merged 1 commit into from
Sep 2, 2024
Merged

[Bug](function) fix encryption_function return wrong result at const column #40201

merged 1 commit into from
Sep 2, 2024

Conversation

zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented Aug 30, 2024 •
edited
Loading

Proposed changes

the string object have error of order, should be src, key,iv,mode

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhangstar333
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 37797 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b0b548a0769606f5cbccac7db569b787bdfc01e7, data reload: false

------ Round 1 ----------------------------------
q1	17610	4353	4336	4336
q2	2018	178	174	174
q3	11666	948	1120	948
q4	10521	727	679	679
q5	7761	2840	2796	2796
q6	225	138	135	135
q7	954	610	596	596
q8	9327	2040	2050	2040
q9	7190	6503	6523	6503
q10	6995	2228	2161	2161
q11	442	232	234	232
q12	392	215	223	215
q13	17947	3047	3048	3047
q14	281	228	225	225
q15	527	499	483	483
q16	578	506	514	506
q17	977	701	738	701
q18	7231	6861	6759	6759
q19	1389	1062	1067	1062
q20	689	341	328	328
q21	3948	2861	3128	2861
q22	1136	1010	1019	1010
Total cold run time: 109804 ms
Total hot run time: 37797 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4278	4335	4251	4251
q2	377	274	277	274
q3	2880	2629	2667	2629
q4	1954	1638	1651	1638
q5	5515	5663	5720	5663
q6	226	130	133	130
q7	2181	1817	1794	1794
q8	3268	3397	3424	3397
q9	8742	8767	8720	8720
q10	3557	3288	3329	3288
q11	607	524	509	509
q12	831	631	674	631
q13	15183	3109	3225	3109
q14	323	288	298	288
q15	532	503	480	480
q16	617	578	596	578
q17	1817	1538	1549	1538
q18	8074	7783	7784	7783
q19	1725	1552	1449	1449
q20	2170	1950	1887	1887
q21	5686	5398	5508	5398
q22	1109	1043	1041	1041
Total cold run time: 71652 ms
Total hot run time: 56475 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193094 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b0b548a0769606f5cbccac7db569b787bdfc01e7, data reload: false

query1	1243	884	868	868
query2	6373	1992	2037	1992
query3	10603	4068	3853	3853
query4	59956	24599	23275	23275
query5	5449	502	497	497
query6	407	179	167	167
query7	5782	294	307	294
query8	287	206	206	206
query9	9010	2478	2466	2466
query10	482	293	261	261
query11	17828	15152	15388	15152
query12	158	110	102	102
query13	1550	397	392	392
query14	11236	7401	7482	7401
query15	225	175	184	175
query16	7550	491	486	486
query17	1113	562	554	554
query18	1949	299	295	295
query19	293	151	156	151
query20	119	122	116	116
query21	206	111	109	109
query22	4650	4502	4370	4370
query23	34320	33887	33376	33376
query24	5999	2843	2871	2843
query25	554	416	396	396
query26	696	162	157	157
query27	1793	280	285	280
query28	3733	2126	2111	2111
query29	711	420	424	420
query30	238	155	151	151
query31	932	769	800	769
query32	90	55	57	55
query33	467	297	284	284
query34	848	483	474	474
query35	852	716	726	716
query36	1045	963	928	928
query37	142	95	93	93
query38	4102	3914	3901	3901
query39	1450	1400	1397	1397
query40	202	123	123	123
query41	52	49	46	46
query42	110	97	96	96
query43	520	490	496	490
query44	1090	753	751	751
query45	198	167	166	166
query46	1112	745	760	745
query47	1933	1803	1781	1781
query48	374	310	301	301
query49	774	433	443	433
query50	821	412	420	412
query51	7254	7026	7081	7026
query52	99	88	88	88
query53	254	183	188	183
query54	590	464	455	455
query55	81	80	79	79
query56	286	265	267	265
query57	1216	1112	1048	1048
query58	225	241	249	241
query59	3199	2887	2784	2784
query60	298	276	276	276
query61	124	117	119	117
query62	741	657	671	657
query63	220	184	190	184
query64	2945	767	739	739
query65	3211	3161	3143	3143
query66	684	370	357	357
query67	15359	15336	15217	15217
query68	4340	608	556	556
query69	402	270	272	270
query70	1181	1055	1149	1055
query71	366	279	282	279
query72	6609	3990	4034	3990
query73	747	328	327	327
query74	9093	8716	8874	8716
query75	3394	2683	2743	2683
query76	1651	941	1009	941
query77	542	313	316	313
query78	9760	9068	9070	9068
query79	1064	542	534	534
query80	849	498	505	498
query81	561	234	231	231
query82	246	191	147	147
query83	203	149	146	146
query84	274	74	74	74
query85	830	286	278	278
query86	353	303	292	292
query87	4431	4197	4225	4197
query88	3203	2304	2303	2303
query89	389	290	281	281
query90	2038	189	196	189
query91	129	97	102	97
query92	61	52	52	52
query93	1760	545	540	540
query94	830	293	284	284
query95	346	257	255	255
query96	592	268	267	267
query97	3219	3039	3111	3039
query98	214	221	242	221
query99	1805	1235	1279	1235
Total cold run time: 309895 ms
Total hot run time: 193094 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.79 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b0b548a0769606f5cbccac7db569b787bdfc01e7, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.06	0.05
query4	1.67	0.07	0.07
query5	0.51	0.51	0.50
query6	1.12	0.73	0.73
query7	0.01	0.01	0.01
query8	0.05	0.04	0.04
query9	0.55	0.49	0.49
query10	0.52	0.52	0.53
query11	0.15	0.12	0.11
query12	0.14	0.12	0.13
query13	0.61	0.58	0.59
query14	2.05	2.02	2.11
query15	0.83	0.82	0.81
query16	0.35	0.37	0.38
query17	0.99	1.03	1.05
query18	0.21	0.20	0.21
query19	1.88	1.80	1.76
query20	0.02	0.01	0.01
query21	15.39	0.66	0.64
query22	3.51	8.70	1.76
query23	18.28	1.41	1.27
query24	2.16	0.21	0.22
query25	0.16	0.08	0.08
query26	0.28	0.18	0.18
query27	0.08	0.07	0.08
query28	13.18	1.03	0.99
query29	12.64	3.30	3.33
query30	0.24	0.05	0.06
query31	2.88	0.40	0.39
query32	3.27	0.49	0.48
query33	2.95	3.06	3.05
query34	16.88	4.37	4.34
query35	4.50	4.42	4.48
query36	0.66	0.49	0.48
query37	0.19	0.16	0.15
query38	0.16	0.14	0.14
query39	0.05	0.03	0.04
query40	0.15	0.12	0.13
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.82 s
Total hot run time: 31.79 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

zclllyybb
zclllyybb approved these changes Aug 31, 2024
View reviewed changes
Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhiqiang-hhhh
zhiqiang-hhhh approved these changes Aug 31, 2024
View reviewed changes
Copy link
Contributor

@zhiqiang-hhhh zhiqiang-hhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

HappenLee
HappenLee reviewed Sep 1, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why performance opt pr Introduce bugs ？ Please add
more test for all · encryption_function`

@yiguolei yiguolei merged commit 79eb367 into apache:master Sep 2, 2024
36 of 40 checks passed
zhangstar333 added a commit to zhangstar333/incubator-doris that referenced this pull request Sep 2, 2024
@zhangstar333
[Bug](function) fix encryption_function return wrong result at const …
3b625e9 
…column (apache#40201)

## Proposed changes

the string object have error of order, should be src, key,iv,mode

<!--Describe your changes.-->
@zhangstar333 zhangstar333 mentioned this pull request Sep 2, 2024
Merged
yiguolei pushed a commit that referenced this pull request Sep 2, 2024
@zhangstar333
[cherry-pick](branch-21) fix encryption_function return wrong result …
70eeda9 
…at const column (#40201) (#40247)

## Proposed changes
cherry-pick from master #40201
the string object have error of order, should be src, key,iv,mode
dataroaring pushed a commit that referenced this pull request Sep 3, 2024
@zhangstar333 @dataroaring
[Bug](function) fix encryption_function return wrong result at const …
5726f16 
…column (#40201)

## Proposed changes

the string object have error of order, should be src, key,iv,mode

<!--Describe your changes.-->
@gavinchou gavinchou mentioned this pull request Oct 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zclllyybb zclllyybb zclllyybb approved these changes

@cambyzju cambyzju cambyzju left review comments

@HappenLee HappenLee HappenLee left review comments

@zhiqiang-hhhh zhiqiang-hhhh zhiqiang-hhhh approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.2-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@zhangstar333 @doris-robot @yiguolei @HappenLee @cambyzju @zhiqiang-hhhh @zclllyybb @dataroaring