Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix](Variant) fix element_at should return nullable if result type is nullable #39732

Merged
merged 1 commit into from
Aug 22, 2024
Merged

[Fix](Variant) fix element_at should return nullable if result type is nullable #39732

merged 1 commit into from
Aug 22, 2024

Conversation

eldenmoon
Copy link
Member

…s nullable

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@eldenmoon
Copy link
Member Author

run buildall

@eldenmoon
Copy link
Member Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39372 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5fd4e04a6287f2f307fbb10ccb3fc8d2bdd1e63a, data reload: false

------ Round 1 ----------------------------------
q1	18903	4856	4482	4482
q2	2618	219	223	219
q3	10769	1175	1221	1175
q4	10671	810	784	784
q5	7877	2966	2928	2928
q6	275	168	164	164
q7	1034	670	666	666
q8	9376	2156	2147	2147
q9	7418	6646	6611	6611
q10	7066	2223	2264	2223
q11	495	286	290	286
q12	426	266	260	260
q13	18676	3027	3040	3027
q14	299	289	257	257
q15	548	523	526	523
q16	527	414	412	412
q17	1028	703	710	703
q18	7520	6891	7009	6891
q19	1478	1182	1087	1087
q20	728	362	356	356
q21	3998	3203	3109	3109
q22	1150	1069	1062	1062
Total cold run time: 112880 ms
Total hot run time: 39372 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4459	4413	4308	4308
q2	412	300	298	298
q3	2954	2663	2678	2663
q4	1949	1666	1654	1654
q5	5432	5423	5403	5403
q6	234	149	149	149
q7	2194	1778	1814	1778
q8	3298	3438	3413	3413
q9	8493	8501	8479	8479
q10	3493	3265	3264	3264
q11	658	556	566	556
q12	835	667	681	667
q13	14520	3085	3059	3059
q14	334	312	313	312
q15	581	536	541	536
q16	510	454	452	452
q17	1820	1518	1503	1503
q18	7824	7515	7556	7515
q19	1774	1723	1567	1567
q20	2112	1857	1907	1857
q21	5592	5181	5242	5181
q22	1188	1096	1104	1096
Total cold run time: 70666 ms
Total hot run time: 55710 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193918 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5fd4e04a6287f2f307fbb10ccb3fc8d2bdd1e63a, data reload: false

query1	968	408	410	408
query2	6743	2094	1997	1997
query3	6669	240	233	233
query4	34221	23253	23215	23215
query5	4430	743	709	709
query6	318	212	210	210
query7	4618	343	335	335
query8	480	429	436	429
query9	8787	2573	2549	2549
query10	511	357	347	347
query11	15772	15288	15255	15255
query12	200	141	137	137
query13	1714	464	463	463
query14	10956	7569	7204	7204
query15	324	193	193	193
query16	7794	480	497	480
query17	1796	611	601	601
query18	2002	367	342	342
query19	366	170	178	170
query20	144	139	136	136
query21	258	151	148	148
query22	4687	4452	4232	4232
query23	34280	33674	33626	33626
query24	11175	2969	2979	2969
query25	645	422	424	422
query26	1515	184	182	182
query27	2546	312	307	307
query28	7234	2132	2112	2112
query29	961	455	447	447
query30	348	185	186	185
query31	1046	848	868	848
query32	123	81	85	81
query33	824	344	369	344
query34	907	518	545	518
query35	884	786	760	760
query36	1114	1001	987	987
query37	170	116	107	107
query38	4001	4003	4023	4003
query39	1535	1476	1468	1468
query40	307	156	158	156
query41	139	138	135	135
query42	143	119	123	119
query43	564	528	542	528
query44	1265	803	814	803
query45	226	197	199	197
query46	1143	783	778	778
query47	1965	1900	1882	1882
query48	412	348	346	346
query49	1267	588	614	588
query50	874	494	473	473
query51	7342	7049	7190	7049
query52	123	111	107	107
query53	298	230	233	230
query54	1034	523	523	523
query55	94	91	93	91
query56	344	320	314	314
query57	1230	1134	1137	1134
query58	330	314	321	314
query59	3109	2990	3012	2990
query60	353	332	332	332
query61	155	150	149	149
query62	880	705	707	705
query63	270	229	232	229
query64	6322	2411	1900	1900
query65	3237	3238	3204	3204
query66	1403	674	672	672
query67	16016	15455	15342	15342
query68	4985	622	601	601
query69	490	328	320	320
query70	1255	1202	1179	1179
query71	375	319	320	319
query72	6442	2378	2148	2148
query73	809	369	374	369
query74	9227	8976	8844	8844
query75	3476	2839	2781	2781
query76	3205	1057	1015	1015
query77	719	464	446	446
query78	9837	9369	9125	9125
query79	1317	586	579	579
query80	1374	614	611	611
query81	604	263	271	263
query82	771	164	155	155
query83	280	218	217	217
query84	262	103	99	99
query85	1326	362	354	354
query86	414	309	373	309
query87	4493	4303	4268	4268
query88	3112	2577	2567	2567
query89	427	329	333	329
query90	1904	244	239	239
query91	156	135	129	129
query92	95	78	79	78
query93	1179	562	568	562
query94	983	331	344	331
query95	398	304	304	304
query96	600	285	289	285
query97	3229	3126	3098	3098
query98	247	229	229	229
query99	1727	1324	1316	1316
Total cold run time: 299629 ms
Total hot run time: 193918 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.1 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5fd4e04a6287f2f307fbb10ccb3fc8d2bdd1e63a, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.67	0.09	0.07
query5	0.50	0.50	0.50
query6	1.14	0.73	0.72
query7	0.02	0.01	0.02
query8	0.05	0.05	0.05
query9	0.54	0.49	0.50
query10	0.56	0.54	0.55
query11	0.16	0.13	0.12
query12	0.17	0.14	0.13
query13	0.63	0.61	0.60
query14	0.76	0.81	0.79
query15	0.85	0.82	0.83
query16	0.37	0.38	0.37
query17	1.04	1.06	1.00
query18	0.21	0.21	0.21
query19	1.87	1.83	1.78
query20	0.01	0.01	0.01
query21	15.40	0.68	0.67
query22	3.74	6.18	2.67
query23	18.32	1.31	1.26
query24	2.07	0.24	0.24
query25	0.16	0.09	0.09
query26	0.27	0.18	0.18
query27	0.09	0.08	0.08
query28	13.26	1.03	1.01
query29	12.63	3.40	3.39
query30	0.43	0.25	0.25
query31	2.80	0.40	0.41
query32	3.25	0.49	0.49
query33	2.97	2.96	3.04
query34	17.07	4.39	4.46
query35	4.41	4.48	4.46
query36	0.68	0.50	0.51
query37	0.21	0.18	0.17
query38	0.17	0.17	0.17
query39	0.07	0.07	0.06
query40	0.18	0.15	0.14
query41	0.11	0.06	0.06
query42	0.07	0.06	0.07
query43	0.06	0.06	0.06
Total cold run time: 109.33 s
Total hot run time: 32.1 s

@eldenmoon
Copy link
Member Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 38896 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 91872705091582da650ad64e625845664f390659, data reload: false

------ Round 1 ----------------------------------
q1	17964	4561	4426	4426
q2	2864	247	215	215
q3	11105	1132	1235	1132
q4	10711	816	784	784
q5	8338	2913	2910	2910
q6	271	168	165	165
q7	1040	675	669	669
q8	9398	2119	2086	2086
q9	7327	6550	6576	6550
q10	7063	2221	2249	2221
q11	503	293	279	279
q12	428	261	266	261
q13	18603	3062	3054	3054
q14	306	250	258	250
q15	562	517	525	517
q16	517	419	416	416
q17	1011	706	752	706
q18	7424	6891	6824	6824
q19	1453	1037	1119	1037
q20	702	346	364	346
q21	3976	3136	3057	3057
q22	1135	1051	991	991
Total cold run time: 112701 ms
Total hot run time: 38896 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4409	4351	4322	4322
q2	418	322	298	298
q3	2888	2681	2682	2681
q4	1997	1678	1668	1668
q5	5413	5416	5402	5402
q6	239	150	156	150
q7	2135	1780	1782	1780
q8	3265	3406	3409	3406
q9	8527	8404	8462	8404
q10	3483	3220	3229	3220
q11	637	531	533	531
q12	824	649	657	649
q13	11845	3044	3075	3044
q14	343	315	300	300
q15	586	541	527	527
q16	527	468	475	468
q17	1852	1527	1529	1527
q18	7958	7423	7451	7423
q19	1744	1580	1567	1567
q20	2106	1847	1875	1847
q21	5511	5303	5232	5232
q22	1180	1071	1064	1064
Total cold run time: 67887 ms
Total hot run time: 55510 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193015 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 91872705091582da650ad64e625845664f390659, data reload: false

query1	951	393	394	393
query2	6741	2047	2036	2036
query3	6667	226	235	226
query4	34137	23337	23216	23216
query5	4413	745	728	728
query6	306	213	231	213
query7	4608	328	332	328
query8	484	432	432	432
query9	8674	2559	2566	2559
query10	530	361	362	361
query11	17563	15037	15135	15037
query12	197	142	136	136
query13	1708	455	455	455
query14	10740	7907	7410	7410
query15	349	200	188	188
query16	7374	530	522	522
query17	1797	612	595	595
query18	1984	338	356	338
query19	352	173	168	168
query20	144	134	135	134
query21	248	141	142	141
query22	4523	4041	4217	4041
query23	34245	33604	33185	33185
query24	11270	2959	2957	2957
query25	656	431	433	431
query26	1184	187	182	182
query27	2455	304	307	304
query28	6553	2129	2101	2101
query29	816	456	455	455
query30	342	184	187	184
query31	1071	854	837	837
query32	120	81	91	81
query33	816	363	353	353
query34	927	529	532	529
query35	905	770	770	770
query36	1148	983	956	956
query37	175	107	108	107
query38	4119	3891	3880	3880
query39	1538	1463	1476	1463
query40	233	156	157	156
query41	140	135	150	135
query42	140	117	120	117
query43	576	520	533	520
query44	1320	803	814	803
query45	233	195	192	192
query46	1145	775	766	766
query47	1971	1843	1878	1843
query48	412	354	343	343
query49	1177	593	604	593
query50	870	478	494	478
query51	7221	7126	7021	7021
query52	121	112	110	110
query53	308	230	228	228
query54	985	514	523	514
query55	92	90	89	89
query56	345	332	330	330
query57	1228	1095	1122	1095
query58	316	303	340	303
query59	3144	2915	3173	2915
query60	366	335	336	335
query61	154	152	145	145
query62	885	708	704	704
query63	271	232	228	228
query64	5489	2383	1878	1878
query65	3235	3206	3179	3179
query66	1156	673	681	673
query67	15620	15395	15371	15371
query68	4975	613	603	603
query69	474	323	327	323
query70	1235	1199	1152	1152
query71	390	332	322	322
query72	6521	2394	2111	2111
query73	812	361	385	361
query74	9337	8948	8901	8901
query75	3507	2774	2829	2774
query76	2900	1132	991	991
query77	683	466	450	450
query78	9651	9128	9160	9128
query79	1210	633	572	572
query80	1243	651	626	626
query81	598	270	259	259
query82	1298	163	158	158
query83	282	224	218	218
query84	251	105	103	103
query85	1081	373	356	356
query86	329	290	298	290
query87	4490	4336	4358	4336
query88	3253	2569	2550	2550
query89	439	336	338	336
query90	2155	243	244	243
query91	158	131	140	131
query92	89	78	78	78
query93	1090	574	556	556
query94	1065	337	341	337
query95	440	308	306	306
query96	610	288	294	288
query97	3245	3112	3139	3112
query98	250	225	223	223
query99	1671	1333	1325	1325
Total cold run time: 297715 ms
Total hot run time: 193015 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.68 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 91872705091582da650ad64e625845664f390659, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.05	0.04
query3	0.23	0.05	0.05
query4	1.66	0.08	0.08
query5	0.50	0.49	0.50
query6	1.13	0.73	0.73
query7	0.02	0.01	0.01
query8	0.06	0.04	0.05
query9	0.56	0.48	0.50
query10	0.55	0.54	0.53
query11	0.17	0.12	0.13
query12	0.17	0.13	0.14
query13	0.63	0.60	0.61
query14	0.77	0.79	0.78
query15	0.84	0.84	0.85
query16	0.39	0.38	0.38
query17	1.02	0.97	0.98
query18	0.21	0.22	0.21
query19	1.97	1.79	1.74
query20	0.01	0.01	0.02
query21	15.39	0.66	0.66
query22	3.92	6.93	2.42
query23	18.23	1.35	1.26
query24	2.11	0.22	0.22
query25	0.16	0.09	0.09
query26	0.27	0.18	0.18
query27	0.08	0.08	0.09
query28	13.37	1.03	1.02
query29	12.64	3.41	3.42
query30	0.43	0.19	0.19
query31	2.79	0.42	0.40
query32	3.23	0.49	0.48
query33	2.98	3.00	3.06
query34	16.85	4.41	4.35
query35	4.52	4.41	4.42
query36	0.68	0.49	0.48
query37	0.22	0.17	0.19
query38	0.18	0.17	0.17
query39	0.07	0.06	0.06
query40	0.19	0.17	0.16
query41	0.12	0.07	0.07
query42	0.08	0.07	0.07
query43	0.07	0.06	0.06
Total cold run time: 109.6 s
Total hot run time: 31.68 s

@xiaokang xiaokang changed the title [Fix](Variant) fix element_at should return nullable if result type i… [Fix](Variant) fix element_at should return nullable if result type is nullable Aug 22, 2024
xiaokang
xiaokang approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit ef7424a into apache:master Aug 22, 2024
28 of 31 checks passed
@eldenmoon eldenmoon removed the doing label Aug 23, 2024
@eldenmoon eldenmoon deleted the fix-var-element_at branch August 23, 2024 02:03
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Aug 23, 2024
@eldenmoon
[Fix](Variant) fix element_at should return nullable if result type i…
5c9ed0f 
…s nullable (apache#39732)

…s nullable

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
@eldenmoon eldenmoon mentioned this pull request Aug 23, 2024
Merged
yiguolei pushed a commit that referenced this pull request Aug 24, 2024
@eldenmoon
[pick](Variant) fix element_at should return nullable if result type …
a6f267c 
…is nullable (#39846)

#39732
dataroaring pushed a commit that referenced this pull request Aug 26, 2024
@eldenmoon @dataroaring
[Fix](Variant) fix element_at should return nullable if result type i…
2129943 
…s nullable (#39732)

…s nullable

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
@gavinchou gavinchou mentioned this pull request Oct 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

@xiaokang xiaokang xiaokang approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.2-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eldenmoon @doris-robot @xiaokang @yiguolei @dataroaring