Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](cancel) Fix wrong status when query failed #38982

Merged
merged 2 commits into from
Aug 7, 2024
Merged

[fix](cancel) Fix wrong status when query failed #38982

merged 2 commits into from
Aug 7, 2024

Conversation

zhiqiang-hhhh
Copy link
Contributor

@zhiqiang-hhhh zhiqiang-hhhh commented Aug 6, 2024 •
edited
Loading

Pipeline task A failed with Status A, pipeline task B should also fail with same Status A instead of just returning a CANCELLED.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions github-actions bot added the doing label Aug 6, 2024
@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 41712 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d3498dfcf6883f159e33a1bd7b1d8124843f95a0, data reload: false

------ Round 1 ----------------------------------
q1	17624	4147	4075	4075
q2	2018	202	202	202
q3	10492	1284	1357	1284
q4	10167	902	957	902
q5	7586	2940	2983	2940
q6	220	141	139	139
q7	1052	622	616	616
q8	9431	1957	1948	1948
q9	8412	6657	6623	6623
q10	8738	3890	3826	3826
q11	422	252	250	250
q12	403	236	238	236
q13	17765	2918	2959	2918
q14	269	246	233	233
q15	524	486	504	486
q16	523	402	389	389
q17	981	942	918	918
q18	8124	7351	7178	7178
q19	1477	1225	1226	1225
q20	567	333	349	333
q21	5347	4706	4804	4706
q22	350	285	287	285
Total cold run time: 112492 ms
Total hot run time: 41712 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4066	4033	4055	4033
q2	327	219	217	217
q3	3000	2995	3189	2995
q4	1984	2034	1977	1977
q5	5574	5522	5433	5433
q6	220	132	136	132
q7	2102	1734	1843	1734
q8	3331	3387	3361	3361
q9	8632	8667	8775	8667
q10	3907	4093	3952	3952
q11	571	465	468	465
q12	779	607	584	584
q13	15871	3132	3102	3102
q14	296	252	252	252
q15	519	479	471	471
q16	446	407	425	407
q17	1800	1710	1704	1704
q18	7774	7284	7195	7195
q19	1669	1677	1675	1675
q20	1975	1780	1748	1748
q21	5412	5263	5244	5244
q22	522	464	480	464
Total cold run time: 70777 ms
Total hot run time: 55812 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 171350 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d3498dfcf6883f159e33a1bd7b1d8124843f95a0, data reload: false

query1	934	381	374	374
query2	6486	1709	1647	1647
query3	6663	214	220	214
query4	19916	17550	17364	17364
query5	4290	501	520	501
query6	297	188	157	157
query7	4606	291	283	283
query8	244	193	207	193
query9	8520	2381	2376	2376
query10	483	274	258	258
query11	10577	10140	10168	10140
query12	133	86	84	84
query13	1604	371	372	371
query14	9432	6816	7562	6816
query15	214	162	163	162
query16	7062	450	458	450
query17	930	557	545	545
query18	1868	278	285	278
query19	193	154	146	146
query20	90	89	87	87
query21	207	102	97	97
query22	4879	4699	4703	4699
query23	33911	33958	33474	33474
query24	10333	3228	3184	3184
query25	716	423	426	423
query26	1699	162	162	162
query27	2946	284	304	284
query28	7751	2057	2032	2032
query29	1266	471	444	444
query30	243	168	160	160
query31	949	786	808	786
query32	105	62	58	58
query33	689	346	364	346
query34	920	493	500	493
query35	877	762	757	757
query36	1044	893	907	893
query37	304	87	91	87
query38	2966	2851	2869	2851
query39	917	843	878	843
query40	278	122	120	120
query41	47	51	47	47
query42	134	103	107	103
query43	501	432	428	428
query44	1226	766	782	766
query45	219	189	193	189
query46	1128	871	798	798
query47	1926	1835	1890	1835
query48	377	305	306	305
query49	970	442	442	442
query50	931	462	454	454
query51	7011	6884	6820	6820
query52	105	92	91	91
query53	257	183	184	183
query54	666	464	532	464
query55	79	74	77	74
query56	274	257	267	257
query57	1156	1074	1029	1029
query58	263	272	271	271
query59	2600	2377	2372	2372
query60	303	279	287	279
query61	96	95	92	92
query62	894	672	673	672
query63	214	182	181	181
query64	5306	1907	1861	1861
query65	3213	3117	3131	3117
query66	1293	327	325	325
query67	15507	15026	15059	15026
query68	6334	564	565	564
query69	718	382	306	306
query70	1133	1087	1062	1062
query71	575	281	277	277
query72	7979	2655	2492	2492
query73	945	330	329	329
query74	6031	5718	5723	5718
query75	4316	2710	2723	2710
query76	4243	1236	1267	1236
query77	745	323	321	321
query78	9591	8982	8896	8896
query79	3299	530	529	529
query80	2378	504	498	498
query81	565	230	233	230
query82	748	152	147	147
query83	292	172	176	172
query84	278	80	78	78
query85	1451	366	297	297
query86	442	311	282	282
query87	3328	3096	3119	3096
query88	3662	2428	2415	2415
query89	417	292	286	286
query90	2011	191	195	191
query91	127	102	100	100
query92	62	49	51	49
query93	4544	607	620	607
query94	914	302	279	279
query95	378	273	270	270
query96	616	291	281	281
query97	3237	3143	3033	3033
query98	227	199	202	199
query99	1619	1290	1280	1280
Total cold run time: 277443 ms
Total hot run time: 171350 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.72 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d3498dfcf6883f159e33a1bd7b1d8124843f95a0, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.05	0.04
query3	0.22	0.04	0.04
query4	1.68	0.07	0.07
query5	0.50	0.48	0.48
query6	1.12	0.72	0.71
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.57	0.51	0.51
query10	0.56	0.56	0.58
query11	0.15	0.11	0.12
query12	0.15	0.12	0.13
query13	0.62	0.60	0.60
query14	0.78	0.80	0.79
query15	0.89	0.87	0.86
query16	0.36	0.35	0.35
query17	1.01	0.99	1.00
query18	0.23	0.21	0.22
query19	1.92	1.78	1.72
query20	0.01	0.01	0.01
query21	15.39	0.76	0.66
query22	4.50	8.23	1.05
query23	17.89	1.40	1.34
query24	2.28	0.21	0.22
query25	0.18	0.07	0.08
query26	0.32	0.22	0.22
query27	0.46	0.23	0.22
query28	13.17	1.01	0.98
query29	12.52	3.29	3.25
query30	0.26	0.06	0.05
query31	2.87	0.41	0.40
query32	3.24	0.50	0.48
query33	2.97	2.93	2.96
query34	15.44	4.26	4.27
query35	4.30	4.30	4.25
query36	0.68	0.49	0.48
query37	0.19	0.16	0.16
query38	0.16	0.15	0.15
query39	0.04	0.04	0.04
query40	0.17	0.13	0.14
query41	0.10	0.05	0.05
query42	0.06	0.04	0.04
query43	0.05	0.04	0.04
Total cold run time: 108.21 s
Total hot run time: 29.72 s

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit dd6991e into apache:master Aug 7, 2024
29 of 31 checks passed
@yiguolei yiguolei removed the doing label Aug 7, 2024
dataroaring pushed a commit that referenced this pull request Aug 11, 2024
@zhiqiang-hhhh @dataroaring
[fix](cancel) Fix wrong status when query failed (#38982)
2fd4056 
Pipeline task A failed with `Status A`, pipeline task B should also fail
with same `Status A` instead of just returning a CANCELLED.
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Aug 14, 2024
@zhiqiang-hhhh @wyxxxcat
[fix](cancel) Fix wrong status when query failed (apache#38982)
87bee3b 
Pipeline task A failed with `Status A`, pipeline task B should also fail
with same `Status A` instead of just returning a CANCELLED.
dataroaring pushed a commit that referenced this pull request Aug 16, 2024
@zhiqiang-hhhh @dataroaring
[fix](cancel) Fix wrong status when query failed (#38982)
b5c9324 
Pipeline task A failed with `Status A`, pipeline task B should also fail
with same `Status A` instead of just returning a CANCELLED.
@gavinchou gavinchou mentioned this pull request Oct 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zclllyybb zclllyybb zclllyybb approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.2-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhiqiang-hhhh @doris-robot @yiguolei @zclllyybb @dataroaring