Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix-#14086]The subprocess type node is always in the ready stop state #14087

Merged
merged 2 commits into from
May 18, 2023

Conversation

fuchanghai
Copy link
Member

Purpose of the pull request

this close:

Brief change log

Verify this pull request

@fuchanghai
Copy link
Member Author

@ruanwenjun @zhuangchong PTAL

Copy link
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (3.0.6-prepare@565bc97). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 5f05871 differs from pull request most recent head d416417. Consider uploading reports for the commit d416417 to get more accurate results

@@               Coverage Diff                @@
##             3.0.6-prepare   #14087   +/-   ##
================================================
  Coverage                 ?   40.32%           
  Complexity               ?     4642           
================================================
  Files                    ?      889           
  Lines                    ?    35252           
  Branches                 ?     3901           
================================================
  Hits                     ?    14214           
  Misses                   ?    19654           
  Partials                 ?     1384           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhongjiajie
Copy link
Member

does it exists in dev branch?

@fuchanghai
Copy link
Member Author

does it exists in dev branch?

As far as I know, first of all, the latest code branch structure has changed, and it does not judge whether the sub-process instance is finished before stopping the task in the parent workflow

image image

@zhongjiajie zhongjiajie added this to the 3.0.6 milestone May 12, 2023
@fuchanghai
Copy link
Member Author

fuchanghai commented May 12, 2023

BTW ,I think we should stop the remote execution of the task first. Then judge the status of the remote task, and finally update the task status in the parent process WDYT@zhongjiajie @ruanwenjun

killRemoteSubprocessInstanc()
if(subprocessInstance.getState.typeisFinish){
currentTask.setState(subprocessInstance.getState)
updateCurrentTaskById
}

或者我们在调用远程任务有返回信息之后,再根据subprocessinstance 的状态来判断是否更新父流程中的task状态
Or we can judge whether to update the task state in the parent process according to the state of the subprocess instance after calling the remote task and returning information

@fuchanghai
Copy link
Member Author

@zhuangchong @zhongjiajie PTAL

@sonarcloud
Copy link

sonarcloud bot commented May 16, 2023

@zhongjiajie zhongjiajie merged commit a626b4c into apache:3.0.6-prepare May 18, 2023
@zhongjiajie
Copy link
Member

zhongjiajie commented May 18, 2023

@fuchanghai BTW, next time you can use close #14086to let pr close references issue when pr merged

@fuchanghai
Copy link
Member Author

@fuchanghai BTW, next time you can use close #14086to let pr close references issue when pr merged

thanks for your reminder

@fuchanghai fuchanghai deleted the fix-#14086 branch May 18, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants