Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Expr::ScalarUDF to use a struct #6284

Merged
merged 1 commit into from
May 8, 2023
Merged

Conversation

jackwener
Copy link
Member

Which issue does this PR close?

Related to #2175 and #3807.

Rationale for this change

following #6281

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Physical Expressions sql SQL Planner labels May 8, 2023
@jackwener jackwener force-pushed the refactor branch 2 times, most recently from 1d8b37a to 69dc569 Compare May 8, 2023 16:02
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 🚀 -- thanks @jackwener

@alamb alamb merged commit 6f53ff2 into apache:main May 8, 2023
@jackwener jackwener deleted the refactor branch May 9, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Physical Expressions sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants