refactor: simplify the make_udf_function macro
#13712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgao
commented
Dec 10, 2024
| ($UDF:ty, $GNAME:ident, $NAME:ident) => { | ||
| #[doc = "Return a [`ScalarUDF`](datafusion_expr::ScalarUDF) implementation "] | ||
| #[doc = stringify!($UDF)] | ||
| ($UDF:ty, $NAME:ident) => { |
There was a problem hiding this comment.
Here is the main change.
comphead
reviewed
Dec 10, 2024
| pub fn $NAME() -> std::sync::Arc<datafusion_expr::ScalarUDF> { | ||
| // Singleton instance of the function | ||
| static $GNAME: std::sync::LazyLock< | ||
| static INSTANCE: std::sync::LazyLock< |
There was a problem hiding this comment.
here we go where lazy lock shines
comphead
approved these changes
Dec 10, 2024
jayzhan211
approved these changes
Dec 11, 2024
|
Thanks @comphead @jayzhan211 for the review |
zhuliquan
pushed a commit
to zhuliquan/datafusion
that referenced
this pull request
Dec 11, 2024
5 tasks
zhuliquan
pushed a commit
to zhuliquan/datafusion
that referenced
this pull request
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow-up of #13674 (comment)
Rationale for this change
By limiting the
ScalarUDFsingleton to the function scope, we can remove$GNAMEfrom themake_udf_functionmacro. Macro callers no longer need to provide a unique singleton name.Before:
After:
What changes are included in this PR?
Are these changes tested?
Yes.
Are there any user-facing changes?
No. Those macros are not exported and are not public APIs.