refactor: replace OnceLock with LazyLock (round 2)
#13674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
jonahgao
commented
Dec 6, 2024
| @@ -332,13 +330,13 @@ async fn evaluate_agg_test(expr: Expr, expected_lines: Vec<&str>) { | |||
| /// Converts the `Expr` to a `PhysicalExpr`, evaluates it against the provided | |||
| /// `RecordBatch` and compares the result to the expected result. | |||
| fn evaluate_expr_test(expr: Expr, expected_lines: Vec<&str>) { | |||
| let batch = test_batch(); | |||
| let batch = &TEST_BATCH; | |||
There was a problem hiding this comment.
This change also avoids a clone.
jonahgao
commented
Dec 6, 2024
| [< STATIC_ $UDAF >] | ||
| .get_or_init(|| { | ||
| /// Singleton instance of [$UDAF], ensures the UDAF is only created once | ||
| static INSTANCE: std::sync::LazyLock<std::sync::Arc<crate::AggregateUDF>> = |
There was a problem hiding this comment.
Narrow the scope to inside the function, so we can use a simpler name.
jonahgao
commented
Dec 6, 2024
| }) | ||
| .clone() | ||
| /// Singleton instance of the function | ||
| static $GNAME: std::sync::LazyLock< |
There was a problem hiding this comment.
$GNAME can be removed, maybe in a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #11687
Replaced the remaining
OnceLocks except for function Documentation instances.Rationale for this change
LazyLock provides a simpler way to define static variables.
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
No