Add fix for iOS file upload. #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 bump, cordova people :-) |
|
Why isnt this in? |
|
This should be definitively in. I created a fork, modified the file as birge did and installed from my modified repo. Would have been nicer taking this from the official repo... |
|
Will you add this fix or any alternative to fix ios file upload? |
|
Thanks for the pull request. I've had a look at it and think it looks good. Before we can merge it though, you need to sign Apache's Contributor License Agreement (can be done online): http://www.apache.org/licenses/#clas |
dvicory
pushed a commit
to appfolio/cordova-plugin-inappbrowser
that referenced
this pull request
May 13, 2016
shatting
pushed a commit
to zoomsquare/cordova-plugin-inappbrowser
that referenced
this pull request
Jul 14, 2016
* commit '4ef6106259bb2cf983cdc83b30d11c806c8e0fec': CB-3360: Set custom inappbrowser user agent for ios Add badges for paramedic builds on Jenkins CB-11381 android: Does not pass sonarqube scan Add pull request template. CB-10866: Adding engine requirements to package.json CB-110003: Adding samples to Readme. CB-10996 Adding front matter to README.md CB-11091 Incremented plugin version. Updated version and RELEASENOTES.md for release 1.4.0 CB-7679 add fix for iOS upload. This closes apache#139 CB-10944 : NoSuchMethodError in InAppBrowser plugin CB-10937 fix stretched icons CB-10760: Fixing README for display on Cordova website CB-10636 Add JSHint for plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to start by saying I don't understand fully what the issue is or how this fixes the issue. I have been having an issue where my cordova app would fall back to the splash screen when I tried to upload a file on iOS. I found the solution here https://issues.apache.org/jira/browse/CB-7679
This is before the fix
and this is after
I am not sure why this fix wasn't already included so I am hoping it just because no one has taken the time to make a PR. Any issues with this?