[CELEBORN-1700][FOLLOWUP] Support ShuffleFallbackCount metric for fallback to vanilla Flink built-in shuffle implementation #3012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteNicholas
force-pushed
the
CELEBORN-1700
branch
2 times, most recently
from
64a123d to
b1baa54
Compare
…lback to vanilla Flink built-in shuffle implementation
SteNicholas
force-pushed
the
CELEBORN-1700
branch
from
b1baa54 to
7edde16
Compare
|
Ping @reswqa, @codenohup. |
codenohup
approved these changes
Dec 19, 2024
|
Hi, @SteNicholas This PR LGTM, but I have a minor question. It seems that the decision to fall back to the built-in shuffle is based on |
|
@codenohup, The difference of implementation that Flink only supports job granular fallback but Spark supports shuffle granular fallback causes above fallback metric situation. I would like to support job granular fallback metrics in another pull request. |
FMX
reviewed
Dec 19, 2024
...mon/src/main/java/org/apache/celeborn/plugin/flink/fallback/ShuffleFallbackPolicyRunner.java
Outdated
Show resolved
Hide resolved
…anilla Flink built-in shuffle implementation
FMX
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support
ShuffleFallbackCountmetric for fallback to vanilla Flink built-in shuffle implementation.Why are the changes needed?
#2932 has already supported fallback to vanilla Flink built-in shuffle implementation, which is lack of
ShuffleFallbackCountmetric to feedback the situation of fallback.Does this PR introduce any user-facing change?
No.
How was this patch tested?
RemoteShuffleMasterSuiteJ#testRegisterPartitionWithProducerForForceFallbackPolicy