Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new clippy lints #4734

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Fix new clippy lints #4734

merged 4 commits into from
Aug 24, 2023

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Aug 24, 2023

Which issue does this PR close?

Closes #.

Rationale for this change

New rust release https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1720-2023-08-24 added new lints

What changes are included in this PR?

Are there any user-facing changes?

@tustvold tustvold added the development-process Related to development process of arrow-rs label Aug 24, 2023
@github-actions github-actions bot added the arrow Changes to the arrow crate label Aug 24, 2023
@@ -16,6 +16,7 @@
// under the License.

//! Defines kernel for length of string arrays and binary arrays
#![allow(clippy::redundant_closure_call)]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fixed properly by #4718

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me -- thank you @tustvold

@tustvold tustvold marked this pull request as draft August 24, 2023 15:09
@github-actions github-actions bot added parquet Changes to the parquet crate arrow-flight Changes to the arrow-flight crate labels Aug 24, 2023
@tustvold tustvold marked this pull request as ready for review August 24, 2023 17:31
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clippy is annoying but it is hard to argue with a net deletion of code 👍

@github-actions github-actions bot added the object-store Object Store Interface label Aug 24, 2023
@tustvold tustvold merged commit dfb1ea2 into apache:master Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate development-process Related to development process of arrow-rs object-store Object Store Interface parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants