Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade etcd version to 3.4.18 for ci #6755

Merged
merged 4 commits into from
Apr 1, 2022
Merged

chore: upgrade etcd version to 3.4.18 for ci #6755

merged 4 commits into from
Apr 1, 2022

Conversation

soulbird
Copy link
Contributor

@soulbird soulbird commented Mar 30, 2022 •
edited
Loading

Description

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

Upgrading etcd version to 3.5.2 for ci. This way we can test the compatibility of apisix with the latest version of etcd

@soulbird soulbird marked this pull request as ready for review March 30, 2022 04:03
@shuaijinchao
Copy link
Member

The reason for the upgrade can be supplemented in the Description.

@soulbird
Copy link
Contributor Author

The reason for the upgrade can be supplemented in the Description.

done

spacewander
spacewander reviewed Mar 30, 2022
View reviewed changes
Copy link
Member

@spacewander spacewander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also update etcd client installation?

spacewander
spacewander reviewed Mar 30, 2022
View reviewed changes
@tokers
Copy link
Contributor

tokers commented Mar 30, 2022

FYI:

This release is no longer recommended for production. Please use v3.4 minor until v3.5.3 is released. Read more in https://github.com/etcd-io/etcd/tree/main/CHANGELOG.

See https://github.com/etcd-io/etcd/releases/tag/v3.5.2 for details.

Shall we use 3.4.x and give our users a hint about this?

@spacewander
Copy link
Member

What about only updating the etcd in the CI? So we can get ready once the new etcd version is available for production.

@soulbird
Copy link
Contributor Author

What about only updating the etcd in the CI? So we can get ready once the new etcd version is available for production.

cc@tokers

@moonming
Copy link
Member

FYI:

This release is no longer recommended for production. Please use v3.4 minor until v3.5.3 is released. Read more in https://github.com/etcd-io/etcd/tree/main/CHANGELOG.

See https://github.com/etcd-io/etcd/releases/tag/v3.5.2 for details.

Shall we use 3.4.x and give our users a hint about this?

agreed with toker. We need to use stable version of etcd

@tokers
Copy link
Contributor

tokers commented Mar 31, 2022

What about only updating the etcd in the CI? So we can get ready once the new etcd version is available for production.

I think so, but I still think we need prompt our users, at least in the docs.

@leslie-tsang
Copy link
Member

What about only updating the etcd in the CI? So we can get ready once the new etcd version is available for production.

IMO, this PR enhanced the ability to adapt to new etcd versions, which is a good sign of that APISIX will quick react to the new stuff. :)

But I'm also concerned that such a radical overhaul might lead to some hidden compatibility issues. It's hard to figure out such a middleware version compatibility issues (which may never happen).

@spacewander
Copy link
Member

What about updating to the latest 3.4.x release: 3.4.18?
The current etcd used in the CI is released 2 years ago, so I think it is time for a upgrade.

@leslie-tsang
Copy link
Member

What about updating to the latest 3.4.x release: 3.4.18? The current etcd used in the CI is released 2 years ago, so I think it is time for a upgrade.

Agree

@tokers
Copy link
Contributor

tokers commented Mar 31, 2022

What about updating to the latest 3.4.x release: 3.4.18? The current etcd used in the CI is released 2 years ago, so I think it is time for a upgrade.

Agree +1.

@moonming
Copy link
Member

moonming commented Mar 31, 2022 via email

@soulbird soulbird changed the title chore: upgrade etcd version to 3.5.2 for ci chore: upgrade etcd version to 3.4.18 for ci Mar 31, 2022
leslie-tsang
leslie-tsang approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@leslie-tsang leslie-tsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @soulbird Thanks for your contribution. :)

@leslie-tsang leslie-tsang mentioned this pull request Mar 31, 2022
Closed
@spacewander spacewander merged commit c9ce036 into apache:master Apr 1, 2022
@leslie-tsang leslie-tsang mentioned this pull request Apr 12, 2022
Closed
5 tasks
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request May 20, 2022
@soulbird @Liu-Junlin
chore: upgrade etcd version to 3.4.18 for ci (apache#6755)
f776ae5 
Co-authored-by: soulbird <zhaothreee@gmail.com>
spacewander pushed a commit that referenced this pull request Jun 30, 2022
@soulbird @spacewander
chore: upgrade etcd version to 3.4.18 for ci (#6755)
08518fe 
Co-authored-by: soulbird <zhaothreee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacewander spacewander

@tokers tokers

@starsz starsz

@tzssangglass tzssangglass

@leslie-tsang leslie-tsang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@soulbird @shuaijinchao @tokers @spacewander @moonming @leslie-tsang @starsz @tzssangglass