Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): free disk space #11081

Merged
merged 2 commits into from
Mar 28, 2024
Merged

fix(ci): free disk space #11081

merged 2 commits into from
Mar 28, 2024

Conversation

motongxue
Copy link
Contributor

@motongxue motongxue commented Mar 22, 2024 •
edited
Loading

Description

Fixes # (bug(ci): ci failing due to incomplete docker image backup)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@shreemaan-abhishek
Copy link
Contributor

The github action you added won't work: https://github.com/apache/apisix/actions/runs/8389436022

@motongxue
Copy link
Contributor Author

@shreemaan-abhishek need an approval for workflows.

@motongxue
Copy link
Contributor Author

How can I pass the test? https://github.com/apache/apisix/actions/runs/8390349306/job/22978748114?pr=11081#step:17:279.

@shreemaan-abhishek
Copy link
Contributor

@motongxue it looks like a flaky failure. I have re-ran that workflow.

Could you please take care of the following as well?
image

@shreemaan-abhishek shreemaan-abhishek linked an issue Mar 23, 2024 that may be closed by this pull request
bug(ci): ci failing due to incomplete docker image backup #11068
Closed
@zll600
Copy link
Contributor

zll600 commented Mar 25, 2024 •
edited
Loading

@motongxue it looks like a flaky failure. I have re-ran that workflow.

Could you please take care of the following as well? image

If the GHE runner's disk is not enough, the step save docker images will always fail(no space left on device). Then the cache in CI will make no sence. So I think free disk space is a better approach.

@motongxue
Copy link
Contributor Author

@motongxue it looks like a flaky failure. I have re-ran that workflow.
Could you please take care of the following as well? image

If the GHE runner's disk is not enough, the step save docker images will always fail(no space left on device). So the cache in CI will make no sence. So I think free disk space is a better approach.

I think so.

starsz
starsz previously approved these changes Mar 26, 2024
View reviewed changes
shreemaan-abhishek
shreemaan-abhishek requested changes Mar 27, 2024
View reviewed changes
ci/free_disk_space.sh Outdated Show resolved Hide resolved
@motongxue motongxue requested a review from starsz March 27, 2024 03:26
@starsz starsz merged commit 71ad87d into apache:master Mar 28, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreemaan-abhishek shreemaan-abhishek shreemaan-abhishek approved these changes

@starsz starsz starsz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(ci): ci failing due to incomplete docker image backup
4 participants
@motongxue @shreemaan-abhishek @zll600 @starsz