Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-2788]Fix failing to create unified catalog when managing more than one formats #2788 #2800

Merged
merged 2 commits into from
May 1, 2024

Conversation

nicochen
Copy link
Contributor

[AMORO-2788]Fix failing to create unified catalog when managing more than one formats #2788

Why are the changes needed?

  • Refer to the issue, it fix the bug that creating a catalog with multiple formats throws exceptions

Close #2788 .

Brief change log

  • Add comma to seperate different formats to response front-end request.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Copy link
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baiyangtx baiyangtx merged commit 568feca into apache:master May 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Fail to create unified catalog when managing more than one formats
2 participants