Do not fail the build if only trove-classifiers change (#43236) #43237
+26
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trove classifiers is a non-code package so generally spaeking we have no need to update it every time it is released, but it would be great if we could update it together with other build dependencies - and not fail the build when only trove classifiers change, but update trove-classifiers nevertheless when we run pre-commit run --hook-stage manual update-build-dependencies --all-files This is very similar to what we already do with UV. This PR achieves that: * in CI we set the env SKIP_TROVE_CLASSIFIERS_ONLY to true * this one will check if the only change in pyproject.toml are trove-classifiers * If so - it only prints warning and exits with success
|
Backport of #43236 |
kaxil
approved these changes
Oct 21, 2024
|
We have some kiota related tests failing "importability" - we need to cherry-pick another fix from main to fix it (on it). |
utkarsharma2
pushed a commit
that referenced
this pull request
Oct 23, 2024
Trove classifiers is a non-code package so generally spaeking we have no need to update it every time it is released, but it would be great if we could update it together with other build dependencies - and not fail the build when only trove classifiers change, but update trove-classifiers nevertheless when we run pre-commit run --hook-stage manual update-build-dependencies --all-files This is very similar to what we already do with UV. This PR achieves that: * in CI we set the env SKIP_TROVE_CLASSIFIERS_ONLY to true * this one will check if the only change in pyproject.toml are trove-classifiers * If so - it only prints warning and exits with success
utkarsharma2
pushed a commit
that referenced
this pull request
Oct 24, 2024
Trove classifiers is a non-code package so generally spaeking we have no need to update it every time it is released, but it would be great if we could update it together with other build dependencies - and not fail the build when only trove classifiers change, but update trove-classifiers nevertheless when we run pre-commit run --hook-stage manual update-build-dependencies --all-files This is very similar to what we already do with UV. This PR achieves that: * in CI we set the env SKIP_TROVE_CLASSIFIERS_ONLY to true * this one will check if the only change in pyproject.toml are trove-classifiers * If so - it only prints warning and exits with success
This was referenced Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trove classifiers is a non-code package so generally spaeking we have no need to update it every time it is released, but it would be great if we could update it together with other build dependencies - and not fail the build when only trove classifiers change, but update trove-classifiers nevertheless when we run
pre-commit run --hook-stage manual update-build-dependencies --all-files
This is very similar to what we already do with UV.
This PR achieves that:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.