Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I think we should remove the count_private option altogether, unless we plan to add a totalContributions field in the future. #2517

Closed
mrsanchez90 opened this issue Feb 13, 2023 · 5 comments
Closed

I think we should remove the count_private option altogether, unless we plan to add a totalContributions field in the future. #2517

mrsanchez90 opened this issue Feb 13, 2023 · 5 comments
Assignees
@anuraghazra
Labels
bug Something isn't working. design Issues, fixes related to design or alignments. important Important repo information. ⭐ top bug Top bug. stats-card Feature, Enhancement, Fixes related to stats the stats card.

Comments

@mrsanchez90
Copy link

mrsanchez90 commented Feb 13, 2023 •
edited by Zo-Bro-23
Loading

I think we should remove the count_private option altogether, unless we plan to add a totalContributions field in the future.

See #2504 (comment).

Originally posted by @Zo-Bro-23 in #2500 (comment)
@Zo-Bro-23 Zo-Bro-23 added bug Something isn't working. design Issues, fixes related to design or alignments. stats-card Feature, Enhancement, Fixes related to stats the stats card. important Important repo information. labels Feb 13, 2023
@rickstaa rickstaa mentioned this issue Feb 14, 2023
Closed
@rickstaa
Copy link
Collaborator

I agree. @anuraghazra, see my comment in #2500 (comment).

@rickstaa rickstaa removed their assignment Feb 14, 2023
@mrsanchez90
Copy link
Author

mrsanchez90 commented Feb 14, 2023 via email

@github-actions github-actions bot mentioned this issue Feb 16, 2023
Open
@rickstaa rickstaa mentioned this issue Apr 24, 2023
Closed
@harucyber
Copy link

I think that it should be left in because it is a feature with the basic default GitHub activity page.

@rickstaa rickstaa mentioned this issue Apr 28, 2023
Merged
@rickstaa rickstaa mentioned this issue May 6, 2023
Closed
@rickstaa
Copy link
Collaborator

I think that it should be left in because it is a feature with the basic default GitHub activity page.

I think the current way of adding contributions to commits is incorrect and should be changed. Ideally, users would have the ability to show or commits or contributions. This information can be retrieved for the current year using GraphQL (see below) but, however, would be a different feature request. You are welcome to open a future request or pull request.

query userInfo($login: String!) {
  user(login: $login) {
    name
    login
    contributionsCollection {
      totalCommitContributions
      totalIssueContributions
      totalPullRequestContributions
      totalPullRequestReviewContributions
      restrictedContributionsCount
      totalRepositoryContributions
    }
  }
}
{"login": "rickstaa"}

rickstaa added a commit that referenced this issue May 19, 2023
@rickstaa
feat: remove 'include_private'
4af416a 
As explained in #2517 the 'include_private' flag is confusing and
doesn't work as expected. This commit therefore removes this flag.
@rickstaa rickstaa mentioned this issue May 19, 2023
Merged
2 tasks
@rickstaa
Copy link
Collaborator

I removed this boolean in #2736 and requested a review of the other collaborators. @mrsanchez90, @RinSoftwareDeveloper or others feel free to add your review to this pull request.

qwerty541 pushed a commit that referenced this issue Jun 7, 2023
@rickstaa
feat: remove 'include_private' (#2736)
b9200c6 
* feat: remove 'include_private'

As explained in #2517 the 'include_private' flag is confusing and
doesn't work as expected. This commit therefore removes this flag.

* fix: fix tests

* docs: remove redundant private deploy note
j4ckofalltrades pushed a commit to j4ckofalltrades/gh-stats that referenced this issue Jun 8, 2023
@rickstaa @j4ckofalltrades
feat: remove 'include_private' (anuraghazra#2736)
f192ca1 
* feat: remove 'include_private'

As explained in anuraghazra#2517 the 'include_private' flag is confusing and
doesn't work as expected. This commit therefore removes this flag.

* fix: fix tests

* docs: remove redundant private deploy note
@rickstaa rickstaa added the ⭐ top bug Top bug. label Jun 15, 2023
devantler pushed a commit to devantler/github-readme-stats that referenced this issue Sep 24, 2023
@rickstaa @devantler
feat: remove 'include_private' (anuraghazra#2736)
7ce6eff 
* feat: remove 'include_private'

As explained in anuraghazra#2517 the 'include_private' flag is confusing and
doesn't work as expected. This commit therefore removes this flag.

* fix: fix tests

* docs: remove redundant private deploy note
setdebarr pushed a commit to setdebarr/github-readme-stats that referenced this issue Jan 12, 2024
@rickstaa @setdebarr
feat: remove 'include_private' (anuraghazra#2736)
7f15f7f 
* feat: remove 'include_private'

As explained in anuraghazra#2517 the 'include_private' flag is confusing and
doesn't work as expected. This commit therefore removes this flag.

* fix: fix tests

* docs: remove redundant private deploy note
jacobbexten pushed a commit to jacobbexten/github-readme-stats that referenced this issue Nov 6, 2024
@rickstaa @jacobbexten
feat: remove 'include_private' (anuraghazra#2736)
0a44b55 
* feat: remove 'include_private'

As explained in anuraghazra#2517 the 'include_private' flag is confusing and
doesn't work as expected. This commit therefore removes this flag.

* fix: fix tests

* docs: remove redundant private deploy note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anuraghazra anuraghazra

Labels
bug Something isn't working. design Issues, fixes related to design or alignments. important Important repo information. ⭐ top bug Top bug. stats-card Feature, Enhancement, Fixes related to stats the stats card.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rickstaa @anuraghazra @Zo-Bro-23 @mrsanchez90 @harucyber