Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 完善 Legend #1283

Merged
merged 6 commits into from
Nov 21, 2021
Merged

fix: 完善 Legend #1283

merged 6 commits into from
Nov 21, 2021

Conversation

El-Chiang
Copy link
Contributor

@El-Chiang El-Chiang commented Nov 19, 2021 •
edited
Loading

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change
  • 修复 Legend position 为 'bottom' 不显示的问题
  • 扩展了 Legend 事件触发
  • 补充了 Legend 动态交互示例

image

El-Chiang
El-Chiang commented Nov 19, 2021
View reviewed changes
packages/f2/src/components/legend/withLegend.tsx

type TriggerMap = {
[triggerType: string]: (items: any[], records: any[], legend) => void;
Copy link
Contributor Author

@El-Chiang El-Chiang Nov 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

回调函数传入三个参数：

  • 原始 legendItems
  • 当前 getSnapRecords() 获取到的 records
  • legend 自身

@lgtm-com
Copy link

lgtm-com bot commented Nov 19, 2021

This pull request introduces 1 alert when merging 1e8dcde into 593b323 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@El-Chiang El-Chiang requested review from zengyue and ACERY1 November 19, 2021 03:48
@lgtm-com
Copy link

lgtm-com bot commented Nov 19, 2021

This pull request introduces 1 alert when merging c1b10bd into 593b323 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@zengyue zengyue merged commit 8c87ca0 into v4.0.x Nov 21, 2021
@zengyue zengyue deleted the fix/legend branch November 21, 2021 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zengyue zengyue zengyue left review comments

@ACERY1 ACERY1 Awaiting requested review from ACERY1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@El-Chiang @zengyue