Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Translation: 한국어 #561

Closed
555cider opened this issue Apr 16, 2023 · 3 comments
Closed

New Translation: 한국어 #561

555cider opened this issue Apr 16, 2023 · 3 comments
Labels
translation 🌍 New or updated translations

Comments

@555cider
Copy link

555cider commented Apr 16, 2023 •
edited
Loading

ko-KR.zip

My name: 555cider
My Github profile: https://github.com/555cider

Without context, I'm not sure this is an accurate translation. So, whenever I find something strange while using it, I will report it.

And I think there are some things to check again. (feel free to ignore).

  1. noOpenTabs in message
    : 'There are no open tabs, navigate on the left bar or:'
    : It's really ending with colon...?
  2. findName in faker
    : 'Full Name'
    : Is it typo...?
@Fabio286 Fabio286 added the translation 🌍 New or updated translations label Apr 16, 2023
@Fabio286
Copy link
Member

Fabio286 commented Apr 17, 2023 •
edited
Loading

Hi @555cider,

thanks for your translation!

  1. noOpenTabs in message
    : 'There are no open tabs, navigate on the left bar or:'
    : It's really ending with colon...?

Correct:

image

  1. findName in faker
    : 'Full Name'
    : Is it typo...?

Not a typo, the faker block refers to faker.js functions name and findName function returns a full name.

@Fabio286
Copy link
Member

@all-contributors please add @555cider for translation.

@allcontributors allcontributors bot mentioned this issue Apr 17, 2023
Merged
@allcontributors
Copy link
Contributor

@Fabio286

I've put up a pull request to add @555cider! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
translation 🌍 New or updated translations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fabio286 @555cider