Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Radio type cannot be override #32463

Merged
merged 1 commit into from
Oct 13, 2021
Merged

fix: Radio type cannot be override #32463

merged 1 commit into from
Oct 13, 2021

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Oct 13, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #32459

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Radio cannot click due to custom type property.
🇨🇳 Chinese 修复 Radio type 属性被覆盖导致无法点击的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@codecov
Copy link

codecov bot commented Oct 13, 2021 •
edited
Loading

Codecov Report

Merging #32463 (82419c7) into master (a6bc104) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #32463   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          414       414           
  Lines         7589      7588    -1     
  Branches      2132      2132           
=========================================
- Hits          7589      7588    -1
Impacted Files Coverage Δ
components/radio/radio.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6bc104...82419c7. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2021 •
edited
Loading

@github-actions
Copy link
Contributor

Size Change: +8 B (0%)

Total Size: 920 kB

Filename Size Change
./dist/antd-with-locales.min.js 354 kB +5 B (0%)
./dist/antd.min.js 304 kB +3 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/antd.compact.min.css 65 kB
./dist/antd.dark.min.css 66.3 kB
./dist/antd.min.css 65.2 kB
./dist/antd.variable.min.css 65.6 kB

compressed-size-action

@afc163 afc163 merged commit 0313871 into master Oct 13, 2021
@afc163 afc163 deleted the fix-radio-type branch October 13, 2021 09:13
@xrkffgg xrkffgg mentioned this pull request Oct 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Radio attribute has type and does not work
1 participant
@afc163