Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Notification closeIcon don't update (#32351) #32359

Merged
merged 2 commits into from
Oct 2, 2021
Merged

fix: Notification closeIcon don't update (#32351) #32359

merged 2 commits into from
Oct 2, 2021

Conversation

KAROTT7
Copy link
Contributor

@KAROTT7 KAROTT7 commented Sep 30, 2021 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#32351

💡 Background and solution

when notification.open({ closeIcon }) time after time, the closeIcon don't update.

📝 Changelog

Language Changelog
🇺🇸 English 🐞 Fix closeIcon don't update
🇨🇳 Chinese 🐞 多次调用组件，closeIcon 未更新

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2021 •
edited
Loading

@afc163
Copy link
Member

afc163 commented Sep 30, 2021

Could you add a test case?

@KAROTT7
Copy link
Contributor Author

KAROTT7 commented Oct 1, 2021

@afc163 A test case had added.

@KAROTT7
Copy link
Contributor Author

KAROTT7 commented Oct 2, 2021

@afc163 Sorry, I saw approval error and try to wok out it. So I merged master branch, I know it's incorrect and force-push correct commit. I am sorry, tell me if code has any problem.

@codecov
Copy link

codecov bot commented Oct 2, 2021 •
edited
Loading

Codecov Report

Merging #32359 (de96c64) into master (b786f25) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #32359   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          414       414           
  Lines         7586      7586           
  Branches      2132      2132           
=========================================
  Hits          7586      7586
Impacted Files Coverage Δ
components/notification/index.tsx 100.00% <100.00%> (ø)
components/table/Table.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b786f25...de96c64. Read the comment docs.

@afc163 afc163 merged commit 27c3b51 into ant-design:master Oct 2, 2021
@KAROTT7 KAROTT7 deleted the fix-notification-closeIcon-not-update branch October 3, 2021 05:37
@PeachScript PeachScript mentioned this pull request Oct 11, 2021
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KAROTT7 @afc163